Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(java17): Upgrade java runtime to JRE17 and compilation using JDK17, but target remains Java11 #2189

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

j-sandy
Copy link
Contributor

@j-sandy j-sandy commented Oct 23, 2024

No description provided.

@dbyron-sf
Copy link
Contributor

@mattgogerly how does this look?

@@ -1,4 +1,4 @@
FROM alpine:3.11
FROM python:3.7-alpine3.16
Copy link
Contributor

@dbyron-sf dbyron-sf Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here are the only diffs from #2171, which failed with:

#9 [linux/amd64 2/8] RUN apk --no-cache add --update       bash       curl       openjdk17-jre       openssl       py-pip       python   && pip install --upgrade awscli==1.18.18   && apk --purge del        py-pip   && rm -rf /var/cache/apk
#9 0.076 fetch http://dl-cdn.alpinelinux.org/alpine/v3.11/main/x86_64/APKINDEX.tar.gz
#9 0.274 fetch http://dl-cdn.alpinelinux.org/alpine/v3.11/community/x86_64/APKINDEX.tar.gz
#9 0.538 ERROR: unable to select packages:
#9 0.552   openjdk17-jre (no such package):
#9 0.552     required by: world[openjdk17-jre]
#9 ERROR: process "/bin/sh -c apk --no-cache add --update       bash       curl       openjdk17-jre       openssl       py-pip       python   && pip install --upgrade awscli==${AWS_CLI_VERSION}   && apk --purge del        py-pip   && rm -rf /var/cache/apk" did not complete successfully: exit code: 1

@dbyron-sf dbyron-sf added the ready to merge Approved and ready for a merge label Oct 24, 2024
@mergify mergify bot added the auto merged label Oct 24, 2024
@mergify mergify bot merged commit f6180f1 into spinnaker:master Oct 24, 2024
5 checks passed
@j-sandy j-sandy deleted the java17 branch October 25, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged ready to merge Approved and ready for a merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants