fix(pipelineGraph): Handling exception when requisiteStageRefIds is not defined #10086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovidiupopa07
approved these changes
Apr 25, 2024
|
Backporting candidate for 1.34.x, 1.33.x and 1.32.x 🥺 ? |
|
@Mergifyio backport release-1.34.x release-1.33.x release-1.32.x |
✅ Backports have been created
|
This was referenced Apr 25, 2024
mergify bot
added a commit
that referenced
this pull request
Apr 25, 2024
…ot defined (#10086) (#10087) (cherry picked from commit 4e1635d) Co-authored-by: Christos Arvanitis <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Apr 25, 2024
…ot defined (#10086) (#10089) (cherry picked from commit 4e1635d) Co-authored-by: Christos Arvanitis <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Apr 25, 2024
…ot defined (#10086) (#10088) (cherry picked from commit 4e1635d) Co-authored-by: Christos Arvanitis <[email protected]>
sahititarigoppula
pushed a commit
to OpsMx/deck-oes
that referenced
this pull request
Jul 2, 2024
…ot defined (spinnaker#10086) (spinnaker#10088) (cherry picked from commit 4e1635d) Co-authored-by: Christos Arvanitis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deck prior to 1.27.x was rendering the pipelines when the first stages didnt have defined the requisiteStageRefIds.
Although this was not ideal it allowed users to template their first stages without the key. After the pipelineGraph updates this is causing an exception and breaking the rendering of the pipelines causing issues to users upgrading.
With this fix it is checked if the key is not defined and defaulting it to a empty array.
After the fix:
Before the fix:
