feat(ecs): Add support for ECS deployment circuit breaker (#10076)

* feat(ecs): Add support for ECS deployment circuit breaker * chore(ecs): rearrange checkbox for deployment circuit breaker to better align with other form elements
spinnaker · Jan 17, 2024 · 32dfea8 · 32dfea8
1 parent 539020a
commit 32dfea8
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/packages/ecs/src/ecs.help.ts b/packages/ecs/src/ecs.help.ts
@@ -36,6 +36,7 @@ const helpContents: { [key: string]: string } = {
   'ecs.placementStrategy':
     '<p>The strategy the container scheduler will be using.  See <a href="http://docs.aws.amazon.com/AmazonECS/latest/developerguide/task-placement-strategies.html" target="_blank">AWS documentation</a> for more details. </p><p>You should at least balance across availability zones</p><p>Custom placement strategies have not been implemented yet.</p>',
   'ecs.platformVersion': '<p>Defaults to the latest platform version.</p>',
+  'ecs.enableDeploymentCircuitBreaker': '<p>Enable circuit breaker for the ECS service.</p>',
   'ecs.capacity.copySourceScalingPoliciesAndActions':
     '<p>Copy Application Autoscaling policies and their associated alarms from the previous ECS service.</p>',
   'ecs.launchtype': '<p>Launch service tasks on your own EC2 instances or on Fargate.</p>',

diff --git a/packages/ecs/src/serverGroup/configure/serverGroupCommandBuilder.service.js b/packages/ecs/src/serverGroup/configure/serverGroupCommandBuilder.service.js
@@ -151,6 +151,7 @@ angular
               copySourceScalingPoliciesAndActions: true,
               preferSourceCapacity: true,
               useSourceCapacity: true,
+              enableDeploymentCircuitBreaker: false,
               viewState: {
                 useAllImageSelection: false,
                 useSimpleCapacity: true,

diff --git a/...ges/ecs/src/serverGroup/configure/wizard/advancedSettings/advancedSettings.component.html b/...ges/ecs/src/serverGroup/configure/wizard/advancedSettings/advancedSettings.component.html
@@ -78,6 +78,16 @@
     </div>
   </div>
 
+  <div class="form-group">
+    <div class="col-md-5 sm-label-right">
+      Enable Deployment Circuit Breaker
+      <help-field key="ecs.enableDeploymentCircuitBreaker"></help-field>
+    </div>
+    <div class="col-md-3">
+      <input type="checkbox" ng-model="$ctrl.command.enableDeploymentCircuitBreaker" />
+    </div>
+  </div>
+
   <div class="form-group">
     <div class="col-md-5 sm-label-right">
       <b>Placement Strategy</b> <help-field key="ecs.placementStrategy"></help-field>