-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(provider/google): Added new disks type for gce in clouddriver #5914
base: master
Are you sure you want to change the base?
Conversation
Added new disks type for gce in clouddriver. currently, only can be used pd-standard and pd-ssd.
Detail in issue link: spinnaker/spinnaker#6814 |
I agree with the issues above. It would be nice to add Balanced Diks and Extreme Disks to GCE. |
My only question given this is an enum:
|
https://github.com/search?q=org%3Aspinnaker%20pd-ssd&type=code FYI quite a few other places look like they'd need to be changed to support this. We can merge this, but more will be required. |
@Mergifyio update |
❌ Mergify doesn't have permission to updateFor security reasons, Mergify can't update this pull request. Try updating locally. |
Added new disks type for gce in clouddriver.
currently, only can be used pd-standard and pd-ssd.
reference link : https://cloud.google.com/compute/docs/disks