Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Unable to list project clusters #5361

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jcavanagh
Copy link
Contributor

The affected code is attempting to merge image lists from the "same" builds across various clusters. In the case of Kubernetes, the list returned from KubernetesImageSummary is immutable.

So, always convert the (maybe) immutable list from the ImageSummary implementation to a regular mutable list.

Resolves #6149

The affected code is attempting to merge image lists from the "same" builds across various clusters. In the case of Kubernetes, the list returned from KubernetesImageSummary is immutable.

So, always convert the (maybe) immutable list from the ImageSummary implementation to a regular mutable list.

Resolves spinnaker#6149
@dbyron-sf
Copy link
Contributor

The change looks good to me. Would you mind adding a test that demonstrates the bug/fix?

@mattgogerly mattgogerly added the ready to merge Approved and ready for a merge label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Approved and ready for a merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants