Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(titus): Set default disruption budget based on job type #5250

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(titus): Set default disruption budget based on job type #5250

wants to merge 1 commit into from

Conversation

aravindmd
Copy link
Contributor

Titus batch jobs submitted through a Run Job pipeline stage defaults to a global default policy, This policy is well suited for services, but inappropriate for batch jobs as it allows to kill running batch jobs, Setting it to self-managed is a better option since this has the setting on Titus to not disrupt the jobs.

@aravindmd aravindmd added the wip label Feb 13, 2021
@aravindmd
Copy link
Contributor Author

Confirmed with Titus , this should work fine.

@robzienert
Copy link
Member

Would do well to have a test for this.

@aravindmd
Copy link
Contributor Author

Would do well to have a test for this.

Agree , will look at adding one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robzienert robzienert robzienert approved these changes

@ajordens ajordens Awaiting requested review from ajordens ajordens is a code owner

@jeyrschabu jeyrschabu Awaiting requested review from jeyrschabu jeyrschabu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aravindmd @robzienert