added step to check make has been run or not #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swastik959
requested review from
endocrimes,
bacongobbler and
michelleN
as code owners
calebschoepp
approved these changes
May 30, 2025
bacongobbler
approved these changes
May 30, 2025
|
Wonderful! Looks like the test failed because some files are out of date. @swastik959 would you mind regenerating those files as well and adding them to this PR? That would be really appreciated. Thank you! |
@bacongobbler done |
bacongobbler
requested changes
Jun 2, 2025
|
@bacongobbler please have a look |
swastik959
force-pushed
the
make-check
branch
2 times, most recently
from
d170a9e to
216f3af
Compare
|
@bacongobbler can you please trigger the CI |
Signed-off-by: swastik959 <[email protected]>
…dependencies to support v1.33 Signed-off-by: swastik959 <[email protected]>
|
Rebased against main. |
|
@bacongobbler the CI has passed please review it now and apologies for delay was caught up in a release 🙏 |
endocrimes
approved these changes
Jun 26, 2025
bacongobbler
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added step to check make has been run or not in the build workflow
solves #342