Skip to content

[templates]: Add support for yarn #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

[templates]: Add support for yarn #305

wants to merge 4 commits into from

Conversation

ThorstenHans
Copy link
Contributor

This PR adds support for yarn as an alternative package manager to all templates in the repository.

@karthik2804
Copy link
Collaborator

@ThorstenHans the above suggested fix needs to be fixed for all the templates.

@ThorstenHans
Copy link
Contributor Author

already pulled the branch... will update in a sec

@radu-matei
Copy link
Member

Anything else blocking this PR?

@ThorstenHans
Copy link
Contributor Author

IMO, we wanted to time this PR with recent refactorings. Adding @karthik2804

@ThorstenHans
Copy link
Contributor Author

I've rebased this PR and incorporated all the recent changes. cc @karthik2804

@karthik2804
clean up templates
9eb6c4b 
Signed-off-by: karthik2804 <[email protected]>
@ThorstenHans
Copy link
Contributor Author

We're currently facing an issue when using yarn as package manager. Although, building the Spin component does not result in an error, the resulting component won't run at all.

The wasm component does not provide necessary exports. It looks like knitwit does not load KNITWIT_SOURCE from the corresponding environment variable. Instead, it's only pulling from npm_config_knitwit_source or falling back to defaults... cc @karthik2804

@karthik2804
Copy link
Collaborator

The issue seems to be how npm and yarn treat case sensitivity differently for env vars in .npmrc. Marking as draft as in the next major release, we will not need to depend on the env vars for build and add yarn as a part of it.

@karthik2804 karthik2804 marked this pull request as draft February 18, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthik2804 karthik2804 karthik2804 approved these changes

@tschneidereit tschneidereit Awaiting requested review from tschneidereit

Assignees
No one assigned
Labels
do-not-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThorstenHans @karthik2804 @radu-matei