Skip to content

feat(*): add K8s distro-specific restarters; update default restarter #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 13, 2025

Conversation

vdice
Copy link
Collaborator

@vdice vdice commented May 5, 2025

Describe your changes

Adds K8s distro-specific restarters to ameliorate the behavior mentioned in #140.*

  • The asterisk is that the k0s and k3d distros still see the same behavior, despite attempted improvements. (Definite follow-up/rabbit hole fodder.)

However, I'm proposing we move forward with the functionality here for a few reasons:

  1. K8s distro-specific restart logic could prove useful in other ways in the future and this lays the foundation for adding/amending them.
  2. The Unknown container termination behavior has been fixed for kind, k3s, rke2, minikube and AKS, out of the k8s distros I tested. Also, a check has been added to our helm smoke test, which currently vets the fix for minikube, kind and microk8s (we can add more distros in the future).

Issue ticket number and link

#140

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • I tested the changes with the following distributions:
    • Kind
    • MiniKube
    • MicroK8s
    • K3d*
    • K0s*
    • K3s
    • Rancher RKE2
    • Azure AKS
    • GCP GKE (Ubuntu nodes)
    • AWS EKS (AmazonLinux2 nodes)
    • AWS EKS (Ubuntu nodes)
    • Digital Ocean Kubernetes

@vdice vdice force-pushed the feat/distro-specific-restarters branch from d5c7f88 to 7c44646 Compare May 5, 2025 17:56
@vdice vdice changed the title WIP: distro-specific restarters WIP: K8s distro-specific restarters May 5, 2025
@vdice vdice force-pushed the feat/distro-specific-restarters branch from 7c44646 to 17531e8 Compare May 9, 2025 01:55
@vdice vdice changed the title WIP: K8s distro-specific restarters feat(*): add K8s distro-specific restarters; update default restarter May 9, 2025
@vdice vdice marked this pull request as ready for review May 9, 2025 16:34
kate-goldenring
kate-goldenring previously approved these changes May 9, 2025
Copy link

@kate-goldenring kate-goldenring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @vdice

Copy link
Member

@voigt voigt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you @vdice!

@vdice vdice merged commit 2e3c81c into spinframework:main May 13, 2025
14 checks passed
@vdice vdice deleted the feat/distro-specific-restarters branch May 13, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants