-
Notifications
You must be signed in to change notification settings - Fork 11
feat(*): add K8s distro-specific restarters; update default restarter #389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vdice
merged 4 commits into
spinframework:main
from
vdice:feat/distro-specific-restarters
May 13, 2025
Merged
feat(*): add K8s distro-specific restarters; update default restarter #389
vdice
merged 4 commits into
spinframework:main
from
vdice:feat/distro-specific-restarters
May 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d5c7f88
to
7c44646
Compare
11 tasks
Signed-off-by: Vaughn Dice <[email protected]>
Signed-off-by: Vaughn Dice <[email protected]>
Signed-off-by: Vaughn Dice <[email protected]>
7c44646
to
17531e8
Compare
kate-goldenring
previously approved these changes
May 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you @vdice
Signed-off-by: Vaughn Dice <[email protected]>
voigt
approved these changes
May 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you @vdice!
This was referenced May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds K8s distro-specific restarters to ameliorate the behavior mentioned in #140.*
k0s
andk3d
distros still see the same behavior, despite attempted improvements. (Definite follow-up/rabbit hole fodder.)However, I'm proposing we move forward with the functionality here for a few reasons:
Unknown
container termination behavior has been fixed forkind
,k3s
,rke2
,minikube
andAKS
, out of the k8s distros I tested. Also, a check has been added to our helm smoke test, which currently vets the fix forminikube
,kind
andmicrok8s
(we can add more distros in the future).Issue ticket number and link
#140
Checklist before requesting a review