Apply gopls modernize pass #5909
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c4rlo
requested review from
evan2645,
amartinezfayo,
sorindumitru,
MarcosDY and
rturner3
as code owners
Recent gopls version contain a "modernize" pass that can also be run
standalone. Run this on the spire repo, with small manual fixups
afterwards.
The command I ran was:
go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix ./...
Signed-off-by: Carlo Teubner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent gopls versions contain a "modernize" pass that can also be run standalone. Run this on the spire repo, with small manual fixups afterwards.
The command I ran was:
If this finds favour, it may also make sense to add this as a linter to CI. It seems golangci-lint won't be adding support for it directly, so we'd have to do it ourselves.