Upgrade to Go 1.22.1 #330
Upgrade to Go 1.22.1 #330
Conversation
go.mod
Outdated
| @@ -1,6 +1,6 @@ | |||
| module github.com/spiffe/spire-controller-manager | |||
|
|
|||
| go 1.21 | |||
| go 1.22 | |||
There was a problem hiding this comment.
We should probably specify the full version here (allowed since go1.21).
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
|
I noticed that when building with the new Go version using |
| status: | ||
| acceptedNames: | ||
| kind: "" | ||
| plural: "" | ||
| conditions: [] | ||
| storedVersions: [] |
There was a problem hiding this comment.
can you revert status removal? there are some cases where it is required,
but controller runtime is no longer generating this... (the same comment for all cases like this)
| @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1 | |||
| kind: CustomResourceDefinition | |||
| metadata: | |||
| annotations: | |||
| controller-gen.kubebuilder.io/version: v0.13.0 | |||
| controller-gen.kubebuilder.io/version: v0.14.0 | |||
There was a problem hiding this comment.
can you update demo with this new generated yamls? (same comment for all yaml)
| @@ -1,6 +1,6 @@ | |||
| module github.com/spiffe/spire-controller-manager | |||
|
|
|||
| go 1.22 | |||
| go 1.22.1 | |||
There was a problem hiding this comment.
why using 1.22.1? I think we must use 1.22
There was a problem hiding this comment.
See #330 (comment)
Signed-off-by: Max Lambrecht <[email protected]>
This PR upgrades the Go version to
1.22.1, affecting the Dockerfile, Makefile, and GitHub Actions workflows (nightly_build.yaml,pr_build.yaml,release_build.yaml). It introduces the.go-versionfile to specify the Go version.