fix(processor): properly apply config file changes

spider-gazelle · Dec 28, 2023 · 3a302cd · 3a302cd
1 parent 498afb9
commit 3a302cd
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 9 deletions.
diff --git a/src/controllers/monitor.cr b/src/controllers/monitor.cr
@@ -151,7 +151,7 @@ class EdgeAI::Monitor < EdgeAI::Base
       begin
         info = File.info(file)
         !info.size.zero? && info.modification_time >= created_after
-      rescue err : File::NotFoundError
+      rescue File::NotFoundError
         nil
       rescue error
         puts "Error obtaining file info for #{file}\n#{error.inspect_with_backtrace}"

diff --git a/src/models/detection_signal.cr b/src/models/detection_signal.cr
@@ -45,5 +45,7 @@ class EdgeAI::DetectionSignal
   def shutdown
     @server.try &.close
     File.delete(@path) rescue nil
+    connections = @mutex.synchronize { @connections.dup }
+    connections.each(&.close)
   end
 end
diff --git a/src/processor.cr b/src/processor.cr
@@ -6,12 +6,8 @@ class EdgeAI::Processor
   alias Pipeline = TensorflowLite::Pipeline::Configuration::Pipeline
 
   def initialize
-    @pipelines = if File.exists?(PIPELINE_CONFIG)
-                   NamedTuple(pipelines: Hash(String, Pipeline)).from_yaml(File.read(PIPELINE_CONFIG))[:pipelines]
-                 else
-                   File.write EdgeAI::PIPELINE_CONFIG, %({"pipelines": {}})
-                   {} of String => Pipeline
-                 end
+    File.write EdgeAI::PIPELINE_CONFIG, %({"pipelines": {}}) unless File.exists?(PIPELINE_CONFIG)
+    @pipelines = read_config
   end
 
   @shutdown : Bool = false
@@ -22,12 +18,19 @@ class EdgeAI::Processor
 
   @pipelines : Hash(String, Pipeline)
 
+  def read_config : Hash(String, Pipeline)
+    NamedTuple(pipelines: Hash(String, Pipeline)).from_yaml(File.read(PIPELINE_CONFIG))[:pipelines]
+  rescue error
+    Log.warn(exception: error) { "failed to read configuration file, applying default" }
+    {} of String => Pipeline
+  end
+
   def monitor_config
     monitor = ConfigChange.instance
-    monitor.on_change do |file_data|
+    monitor.on_change do |_file_data|
       begin
         Log.info { "config update detected" }
-        update_config NamedTuple(pipelines: Hash(String, Pipeline)).from_yaml(file_data)[:pipelines]
+        update_config read_config
       rescue error
         Log.warn(exception: error) { "failed to apply configuration change" }
       end