Fix empty _sources directory created when html_copy_source is False #14074
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression introduced in v8.2.0 where an empty
_sources/directory is created during HTML builds even whenhtml_copy_source = Falseis explicitly set inconf.py.The Bug:
The
prepare_writing()method inStandaloneHTMLBuilderwas checkingself.copysource(a class attribute that always defaults toTrue) instead ofself.config.html_copy_source(the actual user configuration value).The Fix:
Changed the condition on line 574 of
sphinx/builders/html/__init__.pyfrom:Testing:
This is important for users packaging documentation (e.g., Debian packages) who should not have to manually clean up empty directories that shouldn't exist.
References
_StrPathin HTMLBuilder #13045)