replace os path separator into slash in opf spines. #14067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Please add a test and a CHANGES entry. A |
turky
force-pushed
the
feature/path-separator-opf
branch
6 times, most recently
from
e04adb4 to
22574dd
Compare
turky
force-pushed
the
feature/path-separator-opf
branch
from
22574dd to
887b120
Compare
Contributor
Author
|
I've done. review please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In the current implementation of the EPUB Builder, if a reference path contains a delimiter, identity determination does not work as expected on Windows OS, resulting in multiple manifest IDs being assigned to the same file.
This fix will unify the delimiter for reference paths used in manifests to a forward slash, resolving the aforementioned issue.