-
Notifications
You must be signed in to change notification settings - Fork 0
Support Custom Domain #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Implement domain resource CLI
Reconstruct registry of domain resource
Reconstruct registry of route resource
Add new route to Vulcand after adding new domain
Use the latest Vulcand
Discussion about using vulcand as iruka routerAs you also know vulcand is not "production ready" yet. (see "warning": Documentation — Vulcand documentation 2.0 documentation) Because of vulcand is much easier to deploy and configure than nginx, I think vulcand is not so bad choice for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think backendID is more understandable than name.
I couldn't understand what name means at first time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vulcand backend has some settings.
In the near future, it needs to enable to pass VulcandBackendAddOpts to support those setting.
|
hmm... Perhaps you refered to kujira (prototype version for iruka that I developed before) and its schema design about routing and domain is not best. |
(Sorry for large pull request... 🙇 )
WHY
To access applications on Iruka via custom domain.
WHAT
Implement CLI commands:
$ iruka domains$ iruka domain-add$ iruka domain-removeand implement server logic to use custom domain.
It requires Vulcand (>= v0.8.0-beta.2) container for domain-level routing.
When application is created or new container is launched, iruka registers their information to etcd under
/vulcand. Vulcand reads them and distribute requests by itsHostheader.💡 This feature works well with our Sinatra application and custom domain.