lnsweep: lnwatcher needs to keep_waiting for pending hold_invoice #10318
+66
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If RHASH is in lnworker.dont_settle_htlcs, we should not reveal the preimage. But also, we should not disregard the htlc either. lnwatcher needs to keep waiting until either the user cancels/settles the hold invoice, or until the hold_invoice's CLTV expires.
SomberNight
force-pushed
the
202511_lnsweep_keepwatching
branch
from
ab388b5 to
b37f54c
Compare
SomberNight
commented
Nov 28, 2025
Comment on lines
+490
to
+495
| if htlc.payment_hash in chan.lnworker.dont_settle_htlcs: | ||
| txs[prevout] = KeepWatchingTXO( | ||
| name=sweep_info_name + "_for_hold_invoice", | ||
| until_height=htlc.cltv_abs, | ||
| ) | ||
| return None |
Member
Author
There was a problem hiding this comment.
note: needs more thought in light of #10230 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If RHASH is in lnworker.dont_settle_htlcs, we should not reveal
the preimage. But also, we should not disregard the htlc either.
lnwatcher needs to keep waiting until either the user cancels/settles
the hold invoice, or until the hold_invoice's CLTV expires.
TODO: I need to write a test for this!