wizard: raise more specific exc in create_storage() and pass some to crash reporter #10121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies `NewWalletWizard.create_storage()` to raise more specific exception types instead of plain `Exception`. This should allow the calling GUI to separate between non-bug exceptions (like invalid user input), and bugs which should not happen and be passed to the bug reporter.
Differentiate between the `UserFacingException` and other exceptions when creating the storage. Forward other exceptions to the reporter so they can get fixed.
Differentiate between the `UserFacingException` and other exceptions when creating the storage. Forward other exceptions to the reporter so they can get fixed.
f321x
force-pushed
the
qml_create_storage_exc
branch
from
33eb847 to
f92e9e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the exceptions raised by
create_storage()are all plainExceptionand shown as warning in the GUI. This causes us to miss bugs like #10117 because they never get forwarded to the crash reporter.This PR makes the exception types of
create_storage()more specific,UserFacingExceptionare still shown to the user as before, but other exception types are caught in the calling GUI and forwarded to the crash reporter instead.