Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading Symfony dependencies to allow ^7.0 #204

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

tentacode
Copy link
Contributor

@tentacode tentacode commented Mar 28, 2024

Hello there and thanks for the scrapper, cant't wait to try it ! 👋

I could not install PHPScraper on a Symfony 7 project, I figured I'd just fork it.

I don't really know what you do expect as a contribution so don't hesitate to ask for more / redo it yourself or even close it, meanwhile I'm just using my fork and it works.

composer install and tests are passing on PHP 8.3 on my side

@spekulatius
Copy link
Owner

Hello @tentacode,

Thank you for your PR! Can you check the failing "Checks" and see if you can fix them?

Cheers,
Peter

@tentacode
Copy link
Contributor Author

tentacode commented Mar 31, 2024

I upgraded rector to ^0.19, there seem to be a dependency issue with phpstan that has been fixed meanwhile. Also I ran pint to fix coding standard, even though I don't know why the code was not ok. 🤷‍♂️

@tentacode
Copy link
Contributor Author

ping @spekulatius :) if you can restart the workflow so that I can see if it's all ok 👌🙏

@spekulatius
Copy link
Owner

Thanks for the ping @tentacode , it's running :)

@spekulatius
Copy link
Owner

Looks good @tentacode! Thank you! I'll prepare a new release shortly.

@spekulatius spekulatius merged commit 0db799a into spekulatius:master Apr 9, 2024
6 checks passed
@spekulatius
Copy link
Owner

Done, thank you @tentacode!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants