Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add spacetastic endpoints DOC-1138 #16

Merged
merged 14 commits into from
Sep 6, 2024

Conversation

addetz
Copy link
Contributor

@addetz addetz commented Aug 30, 2024

Describe the Change

This PR consists of:

  • Changes to counter route to support page logic.
  • Fixes a hanging test in internal/database_test.go.
  • Updates all DB dependencies to hello-universe-db:1.1.0
  • Leverages testcontainers for all tests removing the need for a local test db.

Review Changes

🎫 DOC-1138

@addetz addetz requested a review from a team as a code owner August 30, 2024 16:34
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes 🚀

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
main.go Show resolved Hide resolved
endpoints/counterRoute.go Show resolved Hide resolved
endpoints/healthRoute.go Show resolved Hide resolved
endpoints/counterRoute_test.go Show resolved Hide resolved
@addetz addetz merged commit b7110ee into main Sep 6, 2024
6 checks passed
@addetz addetz deleted the add-spacetastic-endpoints-doc-1138 branch September 6, 2024 13:45
@vault-token-factory-spectrocloud

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants