improved error 415 (#1185)

* improved error 415 * test added * Fix tests for updated 415 error response Co-authored-by: unknown <[email protected]> Co-authored-by: Ruwan <[email protected]>
spec-first · Nov 4, 2021 · fc6803b · fc6803b
1 parent 7aeb3bd
commit fc6803b
Show file tree

Hide file tree

Showing 4 changed files with 37 additions and 1 deletion.
diff --git a/connexion/decorators/validation.py b/connexion/decorators/validation.py
@@ -158,7 +158,7 @@ def wrapper(request):
                     else:
                         # the body has contents that were not parsed as JSON
                         raise UnsupportedMediaTypeProblem(
-                                       "Invalid Content-type ({content_type}), expected JSON data".format(
+                                       detail="Invalid Content-type ({content_type}), expected JSON data".format(
                                            content_type=request.headers.get("Content-Type", "")
                                        ))
 

diff --git a/tests/api/test_errors.py b/tests/api/test_errors.py
@@ -78,3 +78,11 @@ def test_errors(problem_app):
     problem_as_exception_body = json.loads(problem_as_exception.data.decode('utf-8', 'replace'))
     assert 'age' in problem_as_exception_body
     assert problem_as_exception_body['age'] == 30
+
+    unsupported_media_type = app_client.post('/v1.0/post_wrong_content_type', data='<html></html>', content_type='text/html')
+    assert unsupported_media_type.status_code == 415
+    unsupported_media_type_body = json.loads(unsupported_media_type.data.decode('utf-8', 'replace'))
+    assert unsupported_media_type_body['type'] == 'about:blank'
+    assert unsupported_media_type_body['title'] == 'Unsupported Media Type'
+    assert unsupported_media_type_body['detail'] == 'Invalid Content-type (text/html), expected JSON data'
+    assert unsupported_media_type_body['status'] == 415
diff --git a/tests/fixtures/problem/openapi.yaml b/tests/fixtures/problem/openapi.yaml
@@ -79,6 +79,18 @@ paths:
       responses:
         '200':
           description: Problem exception
+  /post_wrong_content_type:
+    post:
+      description: Unsupported media type
+      operationId: fakeapi.hello.post_wrong_content_type
+      requestBody:
+        content:
+          application/json:
+            schema:
+              type: object
+      responses:
+        200:
+          description: OK
 servers:
   - url: /v1.0
 components:

diff --git a/tests/fixtures/problem/swagger.yaml b/tests/fixtures/problem/swagger.yaml
@@ -101,3 +101,19 @@ paths:
       responses:
         200:
           description: Problem exception
+
+  /post_wrong_content_type:
+    post:
+      description: Unsupported media type
+      operationId: fakeapi.hello.post_wrong_content_type
+      consumes:
+        - application/json
+      parameters:
+        - in: body
+          name: body
+          description: The request body
+          schema:
+            type: object
+      responses:
+        200:
+          description: OK