Fix Errors during Testing

spatie · Nov 30, 2024 · 1e2822d · 1e2822d
1 parent 0b74f72
commit 1e2822d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/src/Commands/Create.php b/src/Commands/Create.php
@@ -36,7 +36,7 @@ public function handle()
         }
 
         $extraOptions = $this->option('extraOptions') ?: config('db-snapshots.extraOptions', []);
-        $extraOptions = is_string($extraOptions) ? explode(',', $exclude) : $exclude;
+        $extraOptions = is_string($extraOptions) ? explode(',', $extraOptions) : $extraOptions;
 
 
         $snapshot = app(SnapshotFactory::class)->create(

diff --git a/src/Events/CreatingSnapshot.php b/src/Events/CreatingSnapshot.php
@@ -11,7 +11,8 @@ public function __construct(
         public FilesystemAdapter $disk,
         public string $connectionName,
         public ?array $tables = null,
-        public ?array $exclude = null
+        public ?array $exclude = null,
+        public ?array $extraOptions = null
     ) {
         //
     }

diff --git a/src/SnapshotFactory.php b/src/SnapshotFactory.php
@@ -36,10 +36,11 @@ public function create(string $snapshotName, string $diskName, string $connectio
             $disk,
             $connectionName,
             $tables,
-            $exclude
+            $exclude,
+            $extraOptions
         ));
 
-        $this->createDump($connectionName, $fileName, $disk, $compress, $tables, $exclude);
+        $this->createDump($connectionName, $fileName, $disk, $compress, $tables, $exclude, $extraOptions);
 
         $snapshot = new Snapshot($disk, $fileName);
 
@@ -64,7 +65,7 @@ protected function getDbDumper(string $connectionName): DbDumper
         return $factory::createForConnection($connectionName);
     }
 
-    protected function createDump(string $connectionName, string $fileName, FilesystemAdapter $disk, bool $compress = false, ?array $tables = null, ?array $exclude = null): void
+    protected function createDump(string $connectionName, string $fileName, FilesystemAdapter $disk, bool $compress = false, ?array $tables = null, ?array $exclude = null, array $extraOptions = []): void
     {
         $directory = (new TemporaryDirectory(config('db-snapshots.temporary_directory_path')))->create();