feat: add symlink support, exception handling, version bump, and httpd image update #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes made in this commit include: - new api for symlink and related dataclasses - support for command execution in pod
…pd image - Handled the exception related to the symlink feature, for proper error reporting and system stability during symlink processing. - Bumped up the application version following standard semantic versioning due to changes and improvements. - Updated the httpd container image version for enhanced security and performance.
Update Handling of Symlink Feature Exception and Version Bump
…PR review fo the new image is not done.
| Tuple2<String, String> sourceTargetTuple = Tuple2.of(form.metadata().get("source"), | ||
| form.metadata().get("target")); | ||
| boolean isCreated = exec.createSymlink(form.environment(), sourceTargetTuple); | ||
| return "{\"created\":"+isCreated+"}"; |
There was a problem hiding this comment.
Enhancement: This is a very generic response, Specific Response to be created for the symlink operations
There was a problem hiding this comment.
I agree, we should make this change in the next iteration
| public class CommandExecutionService { | ||
|
|
||
|
|
||
| // todo :scope of improvement: read these two vars from the config map |
| }); | ||
| } | ||
|
|
||
| // todo :must do: 1. check both source and destination exists 2. Validate and sanitize the |
Comment on lines
+95
to
+96
| .inContainer(CONTAINER_NAME).readingInput(System.in). //TODO replace the deprecated method | ||
| // with the new method |
soumyadip007
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
@arkaprovob it looks good to me. I've added couple of enhancements, we can discuss on these separately
| }).exec(command)) { | ||
| latch.await(); | ||
| } catch (Exception e) { | ||
| throw new CommandExecutionException("Error while executing command in container", e); |
There was a problem hiding this comment.
Enhancement: In case of exception a proper message should be communicated to the user (via API response/SSE events). To be discussed.
soumyadip007
changed the title
soumyadip007
changed the title
|
@arkaprovob please do the |
arkaprovob
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request introduces changes related to Symlink support
Commit 1 - Feature: Add support for symlinks at the SPAship operator level
Commit 2 - Chore: Handle symlink feature exception, bump version, and update httpd image