Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Unable to Destroy Create Failed Bucket #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

computeracer
Copy link

To Reproduce:

  1. Create a stack with an improper bucket name.
SparkleFormation.new(:bucket_test, :provider => :aws) do

  dynamic!(:bucket, :bucket_one) do
    depends_on 'Bucket2Bucket'
    properties do
      bucket_name 'Bad-bucketname2334'
    end
  end

  dynamic!(:bucket, :bucket2) do
    properties do
      bucket_name 'test122354'
    end
  end
end
  1. Try to destroy the stack with sfn_bucketpurge 0.0.1 enabled, and find
    the following error along with remaining stack.
[ERROR]: no implicit conversion of nil into String

- Fixes bug sparkleformation#2
  where the callback was unable to destroy a stack that contains
  a bucket in the 'CREATE_FAILED' state.

To Reproduce:

1. Create a stack with an improper bucket name.
  ```
  SparkleFormation.new(:bucket_test, :provider => :aws) do

    dynamic!(:bucket, :bucket_one) do
      depends_on 'Bucket2Bucket'
      properties do
        bucket_name 'Bad-bucketname2334'
      end
    end

    dynamic!(:bucket, :bucket2) do
      properties do
        bucket_name 'test122354'
      end
    end
  end
  ```
2. Try to destroy the stack with sfn_bucketpurge 0.0.1 enabled, and find
   the following error along with remaining stack.
  ```
  [ERROR]: no implicit conversion of nil into String
  ```
@computeracer
Copy link
Author

@chrisroberts would you have time to review this small bug fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant