Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add global notice #432

Merged
merged 16 commits into from
Jan 6, 2024
Merged

Add global notice #432

merged 16 commits into from
Jan 6, 2024
+246 −0

Conversation

ddungiii
Copy link
Member

@ddungiii ddungiii commented Nov 9, 2023 •
edited
Loading

Global Notice (글로벌 공지) 기본 API 구현했습니다.

  • admin 구현하여 admin 페이지에서 생성 및 수정할 수 있습니다.
  • GET은 public API이고, GET을 제외한 UNSAFE METHOD는 staff 혹은 superuser만 처리할 수 있습니다.

@ddungiii ddungiii self-assigned this Nov 9, 2023
@ddungiii ddungiii changed the title feat(globalNotice): init global_notice app feat/Global notice Nov 9, 2023
@ddungiii ddungiii linked an issue Nov 9, 2023 that may be closed by this pull request
Global Notice #428
Closed
4 tasks
@ddungiii ddungiii force-pushed the feat/global-notice branch from d0f3a0b to 8b30667 Compare January 2, 2024 13:59
@ddungiii ddungiii force-pushed the feat/global-notice branch from 8b30667 to e45fa08 Compare January 2, 2024 14:00
ddungiii
ddungiii commented Jan 2, 2024
View reviewed changes
@ddungiii ddungiii marked this pull request as ready for review January 2, 2024 14:10
@ddungiii ddungiii requested a review from injoonH January 2, 2024 14:10
injoonH
injoonH reviewed Jan 2, 2024
View reviewed changes
@ddungiii
Copy link
Member Author

ddungiii commented Jan 3, 2024

23bd73e
title, content 모두 ko, en 버전 추가했습니다

@injoonH injoonH changed the title feat/Global notice Add global notice Jan 5, 2024
injoonH
injoonH reviewed Jan 5, 2024
View reviewed changes
injoonH
injoonH reviewed Jan 5, 2024
View reviewed changes
@injoonH injoonH self-assigned this Jan 5, 2024
@injoonH injoonH added enhancement New feature or request good first issue Good for newcomers labels Jan 5, 2024
@ddungiii ddungiii force-pushed the feat/global-notice branch from 2ec3db9 to c46a07b Compare January 5, 2024 14:27
injoonH
injoonH approved these changes Jan 6, 2024
View reviewed changes
Copy link
Member

@injoonH injoonH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@injoonH injoonH merged commit 30cd44f into develop Jan 6, 2024
@injoonH injoonH deleted the feat/global-notice branch January 6, 2024 07:04
@injoonH injoonH mentioned this pull request Jan 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@injoonH injoonH

Assignees

@ddungiii ddungiii

@injoonH injoonH

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Global Notice
2 participants
@ddungiii @injoonH