Expiration time support#2
Conversation
m-ali-akbay
left a comment
There was a problem hiding this comment.
LGTM but I have some questions in my mind to be answered before having the approve.
| }, | ||
| accessory: { | ||
| type: "datepicker", | ||
| initial_date: "2021-12-17", |
There was a problem hiding this comment.
What about having 1 day later from now always as the initial_date and the same behaviour for the initial_time?
Also, I wonder if it complaint with different timezones.
|
The date-time is now calculated dynamically based on the user's timezone. |
m-ali-akbay
left a comment
There was a problem hiding this comment.
Moment.js is not maintained anymore, DateFns is another good alternative. It also uses builtin Date object, which is better to use.
And, what about showing the time left in the message instead of the date-time, and updating it periodically?
| "dependencies": { | ||
| "@slack/bolt": "^3.8.1", | ||
| "dotenv": "^10.0.0", | ||
| "moment": "^2.29.1", |
There was a problem hiding this comment.
moment is being deprecated, please use the successor, date-fns.
Is any new permission required to access the user info? |
No description provided.