Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eigen: remove unnecessary dependency on fortran #47866

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

alalazo
Copy link
Member

@alalazo alalazo commented Dec 2, 2024

Extracted from #45189

tldahlgren
tldahlgren previously approved these changes Dec 2, 2024
Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HaoZeke Do you want to review this PR before it is merged?

@tldahlgren tldahlgren self-assigned this Dec 2, 2024
Copy link
Member

@HaoZeke HaoZeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit about the wording, otherwise looks good.

var/spack/repos/builtin/packages/eigen/package.py Outdated Show resolved Hide resolved
@alalazo
Copy link
Member Author

alalazo commented Dec 3, 2024

@HaoZeke Should be fine now, let me know

Copy link
Member

@HaoZeke HaoZeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @alalazo

@alalazo alalazo merged commit 2aaf50b into spack:develop Dec 4, 2024
15 checks passed
@alalazo alalazo deleted the packages/eigen branch December 4, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants