RPackage: include archive URL for old versions in urls attribute#4060
Open
alecbcs wants to merge 4 commits intospack:developfrom
Open
RPackage: include archive URL for old versions in urls attribute#4060alecbcs wants to merge 4 commits intospack:developfrom
alecbcs wants to merge 4 commits intospack:developfrom
Conversation
Signed-off-by: Alec Scott <alec@llnl.gov>
wdconinc
reviewed
Mar 31, 2026
Signed-off-by: Alec Scott <alec@llnl.gov>
becker33
previously approved these changes
Mar 31, 2026
haampie
requested changes
Apr 1, 2026
Signed-off-by: Alec Scott <alec@llnl.gov>
alecbcs
force-pushed
the
fix/old-r-package-urls
branch
from
abe216c to
109d6ad
Compare
haampie
previously approved these changes
Apr 1, 2026
Member
|
Don't we support urls (plural) too? I don't get this part, but also haven't look at the implementation
It sounds suboptimal even if it works |
Signed-off-by: Alec Scott <alec@llnl.gov>
Member
Author
|
I originally stayed away from using |
alecbcs
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where we had previously been silently falling back to spidering urls for old versions of
r-*packages since we weren't correctly modeling the archive URL. This PR swaps to setting the urls attribute on the class with both the archive url path and the latest version path.