-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Modernize setup and test infrastructure #115
Conversation
* Modernize package setup and RTD settings. * Fix doc build warnings. * Fix doc broken links. * Remove mention of PyRAF in doc and most of the code. * Remove mention of deprecated modules from API doc listing. * Update year on license and doc page.
* Modernize Travis settings. * Add PEP 517 job. * Add linkcheck job. * Use pytest-astropy-header in test header.
* Display pytest header correctly. * Make test generate output in tmpdir, not cwd. * Close open file in test gracefully. * Ignore remaining ResourceWarning, see spacetelescope#119.
073abf2
to
8d46239
Compare
Hmm. I am unable to get the proper |
This is ready for review. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't worked through the doc changes, but the functional adjustments don't look scary.
8e8e33a
to
427b727
Compare
Was hoping the PR builder would work. Let's hold off on merging until it works, so you can see the docs. |
Update: Doc for the PR is at https://stscitools--115.org.readthedocs.build/en/115/ even though it is not reporting back to the PR here. |
Let's just merge this then, since the rendered doc is fine. I will figure out the RTD webhook with RTD devs separately. |
tmpdir
, not current working dir.ResourceWarning
for now. See TST: Investigate ResourceWarning unclosed file #119