Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase minimum versions to match jwst #399

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Feb 11, 2025

This PR updates a few dependencies to match those in jwst:

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run jwst regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.21%. Comparing base (4e83608) to head (153f643).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #399      +/-   ##
==========================================
+ Coverage   78.16%   78.21%   +0.04%     
==========================================
  Files         115      115              
  Lines        5144     5155      +11     
==========================================
+ Hits         4021     4032      +11     
  Misses       1123     1123              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram changed the title increase minimum asdf astropy version increase minimum versions to match jwst Feb 11, 2025
@braingram braingram marked this pull request as ready for review February 12, 2025 15:07
@braingram braingram requested a review from a team as a code owner February 12, 2025 15:07
Copy link
Contributor

@emolter emolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but a question. Is there value in having upper pins here, too? I see an upper pin on asdf in jwst specifying <5

@braingram
Copy link
Collaborator Author

LGTM, but a question. Is there value in having upper pins here, too? I see an upper pin on asdf in jwst specifying <5

Thanks!

I'd say yes and no. Adding an upper pin if we know there will be incompatible changes that we expect will break the code seems worthwhile so that the old versions on pypi don't suddenly start failing when dependencies are updated. However since this is more a "library" than an "application" (like jwst) having as loose as possible pins is helpful for building environments. If we don't have an expectation that the newer versions of dependencies will break this package I'd say we can leave off the upper pins. For asdf in particular there are no plans for breaking changes in 5 that would impact stdatamodels (although the plan for 5.0 is not finalized).

@braingram braingram enabled auto-merge (squash) February 12, 2025 15:37
@braingram braingram merged commit e1256f8 into spacetelescope:main Feb 12, 2025
19 checks passed
@braingram braingram deleted the bump_asdf_astropy branch February 12, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants