-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
increase minimum versions to match jwst #399
Conversation
99414d8
to
420bf2a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #399 +/- ##
==========================================
+ Coverage 78.16% 78.21% +0.04%
==========================================
Files 115 115
Lines 5144 5155 +11
==========================================
+ Hits 4021 4032 +11
Misses 1123 1123 ☔ View full report in Codecov by Sentry. |
420bf2a
to
42539e0
Compare
74c28b2
to
153f643
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but a question. Is there value in having upper pins here, too? I see an upper pin on asdf in jwst specifying <5
Thanks! I'd say yes and no. Adding an upper pin if we know there will be incompatible changes that we expect will break the code seems worthwhile so that the old versions on pypi don't suddenly start failing when dependencies are updated. However since this is more a "library" than an "application" (like jwst) having as loose as possible pins is helpful for building environments. If we don't have an expectation that the newer versions of dependencies will break this package I'd say we can leave off the upper pins. For asdf in particular there are no plans for breaking changes in 5 that would impact stdatamodels (although the plan for 5.0 is not finalized). |
This PR updates a few dependencies to match those in jwst:
Tasks
docs/
pageno-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)jwst
regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>"
)news fragment change types...
changes/<PR#>.feature.rst
: new featurechanges/<PR#>.bugfix.rst
: fixes an issuechanges/<PR#>.doc.rst
: documentation changechanges/<PR#>.removal.rst
: deprecation or removal of public APIchanges/<PR#>.misc.rst
: infrastructure or miscellaneous change