-
Notifications
You must be signed in to change notification settings - Fork 19
RCAL-959 COSMOS and GAIA Sources in Catalogs #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RCAL-959 COSMOS and GAIA Sources in Catalogs #199
Conversation
…to RCAL-959_COSMOSMatching
…to RCAL-959_COSMOSMatching
…to RCAL-959_COSMOSMatching
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #199 +/- ##
==========================================
+ Coverage 80.71% 89.63% +8.91%
==========================================
Files 17 17
Lines 2287 2277 -10
==========================================
+ Hits 1846 2041 +195
+ Misses 441 236 -205 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Setting this ready for review, as the failing tests are in main, not this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Can you add a section to the documentation with maybe your image and a little bit of information? i.e.:
- density of sources
- method for simulating Roman fluxes (linear interpolation among ultra vista wavelengths)
- depth of simulation (incomplete beyond mag ~ 25 IIRC?---not super deep)
- basic simulation parameters (random angles, flat distribution of sersic indices, sizes from COSMOS HST imaging)
- ... something else I'm forgetting?
- real Gaia stars with approximate fluxes (no real colors)
Re the density, can you remind me if you think it is right? Right now you compute the area as (ramax - ramin) * (decmax - decmin), and then get the density as the number divided by the area. I worry that the ultra vista area is only a portion of the whole field, and so (ramax - ramin) * (decmax - decmin) isn't a good approximation of the area that you end up keeping after the cuts. Did you check that?
Can you also say what ends up in the "streamlined" catalog? The size is reasonable so it's okay from that perspective, but we should probably ask permission before providing it as an alternative source of the COSMOS catalog unless it's sufficiently stripped down as to have limited scientific value beyond our use case. We should also cite the COSMOS papers extensively in your new docs.
The streamlined catalog has had the following cuts from the full COSMOS catalog:
These cuts trim the total number of objects from 1720700 to 345994. The filters in particular are very Roman-specific. |
…to RCAL-959_COSMOSMatching
…to RCAL-959_COSMOSMatching
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Can I ask you to make one 3-color image using your new catalog? I'd simulate an image in each of three bands, read each of the images into memory, and use this function
https://github.com/spacetelescope/romanisim/blob/main/romanisim/util.py#L74
to try to get a good scaling. Mostly it would be good to see that the colors look kind of realistic. It would be good to replace the current black/white image with this one.
Image looks good, thanks. Can you help me with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge when ready, thanks!
I have removed the duplicate code in romanisim-gaia-catalog and confirmed the output remained effectively unchanged. |
Adding methods to select random COSMOS galaxies and/or GAIA stars to make more realistic catalogs.