Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop python 3.8 support #112

Merged
merged 1 commit into from
Dec 22, 2023
Merged

drop python 3.8 support #112

merged 1 commit into from
Dec 22, 2023

Conversation

falkben
Copy link
Member

@falkben falkben commented Dec 21, 2023

asdf dependencies don't allow 3.8 (see PR: #105)

we can drop 3.8 (and probably should, since astropy has also dropped 3.8 for newer releases)

@falkben falkben requested a review from havok2063 December 21, 2023 20:45
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (443a9b9) 94.53% compared to head (48856b3) 94.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #112   +/-   ##
=======================================
  Coverage   94.53%   94.53%           
=======================================
  Files           8        8           
  Lines        1446     1446           
=======================================
  Hits         1367     1367           
  Misses         79       79           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@havok2063 havok2063 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@falkben falkben merged commit b79e8b1 into main Dec 22, 2023
8 checks passed
@falkben falkben deleted the drop_py_38 branch December 22, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants