Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[athena-poc] change principal address calculation #6526

Closed

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Dec 6, 2024

Changed how the principal address is calculated to follow https://community.spacemesh.io/t/proposed-athena-design/433#type-1-self-spawn-4. Previously, it used a types.GenerateAddress() which reserves 4B (puts zeros there).

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Base automatically changed from athena-spawning-deployed-templates to athena-poc December 6, 2024 12:47
@poszu poszu changed the title cleanup [athena-poc] change principal address calculation Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

❌ 27 Tests Failed:

Tests completed Failed Passed Skipped
12077 27 12050 10
View the top 3 failed tests by shortest run time
github.com/spacemeshos/go-spacemesh/api/grpcserver TestMeshService/AccountMeshDataQuery/filter_with_valid_AccountId_and_AccountMeshDataFlags_tx_only
Stack Traces | 0s run time
=== RUN   TestMeshService/AccountMeshDataQuery/filter_with_valid_AccountId_and_AccountMeshDataFlags_tx_only
    grpcserver_test.go:915: 
        	Error Trace:	.../api/grpcserver/grpcserver_test.go:915
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unknown desc = failed to parse Filter.AccountId.Address `sm1ezehmmgamhyjtm0qn2cckdv5rgj83g6jsuh3fdsakl0xz`: expected first 4 bytes to be 0, got 200: missing reserved space
        	Test:       	TestMeshService/AccountMeshDataQuery/filter_with_valid_AccountId_and_AccountMeshDataFlags_tx_only
--- FAIL: TestMeshService/AccountMeshDataQuery/filter_with_valid_AccountId_and_AccountMeshDataFlags_tx_only (0.00s)
github.com/spacemeshos/go-spacemesh/api/grpcserver TestMeshService/AccountMeshDataQuery/max_results_page_2
Stack Traces | 0s run time
=== RUN   TestMeshService/AccountMeshDataQuery/max_results_page_2
    grpcserver_test.go:986: 
        	Error Trace:	.../api/grpcserver/grpcserver_test.go:986
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unknown desc = failed to parse Filter.AccountId.Address `sm1ezehmmgamhyjtm0qn2cckdv5rgj83g6jsuh3fdsakl0xz`: expected first 4 bytes to be 0, got 200: missing reserved space
        	Test:       	TestMeshService/AccountMeshDataQuery/max_results_page_2
--- FAIL: TestMeshService/AccountMeshDataQuery/max_results_page_2 (0.00s)
github.com/spacemeshos/go-spacemesh/api/grpcserver TestSmesherService
Stack Traces | 0s run time
=== RUN   TestSmesherService
--- FAIL: TestSmesherService (0.00s)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@poszu poszu marked this pull request as draft December 6, 2024 13:39
@poszu poszu closed this Feb 6, 2025
@fasmat fasmat deleted the athena-update-principal-address-calculation branch February 28, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants