Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Spacedrive process being Killed during lauch on macOS #825

Merged
merged 1 commit into from
May 17, 2023

Conversation

HeavenVolkoff
Copy link
Member

macOS (Ventura? arm?) requires all dylibs to be signed to allow a process to launch¹.

This PR locally signs our ffmpeg dylibs with the machine's local certificate in the setup-system script after downloading them to work around this issue.

@vercel
Copy link

vercel bot commented May 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
spacedrive-landing ✅ Ready (Inspect) Visit Preview May 17, 2023 7:21pm
spacedrive-web ✅ Ready (Inspect) Visit Preview May 17, 2023 7:21pm

@HeavenVolkoff HeavenVolkoff requested a review from utkubakir May 17, 2023 19:21
Copy link
Contributor

@brxken128 brxken128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested but the changes seem sound!

(great work on figuring out a fix so quickly btw)

@fogodev fogodev added this pull request to the merge queue May 17, 2023
Merged via the queue into main with commit eed7ad1 May 17, 2023
@utkubakir utkubakir deleted the fix-macos-ffmpeg-dylibs branch May 17, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants