-
Notifications
You must be signed in to change notification settings - Fork 299
Fix quickstart section in README #501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -422,14 +422,18 @@ Read the full vision in the [roadmap](docs/content/docs/(deployment)/roadmap.mdx | |||||||||||||
| ### Build and Run | ||||||||||||||
|
|
||||||||||||||
| ```bash | ||||||||||||||
| git clone https://github.com/spacedriveapp/spacebot | ||||||||||||||
| git clone https://github.com/spacedriveapp/spacebot.git | ||||||||||||||
| cd spacebot | ||||||||||||||
|
|
||||||||||||||
| # Optional: build the OpenCode embedded UI (requires Node 22+ and bun) | ||||||||||||||
| # Without this, OpenCode workers still work — the Workers tab shows a transcript view instead. | ||||||||||||||
| # ./scripts/build-opencode-embed.sh | ||||||||||||||
| # Build the web UI (React + Vite, embedded into the binary) | ||||||||||||||
| cd interface && bun install && npm i && bun build && cd .. | ||||||||||||||
|
|
||||||||||||||
| cargo build --release | ||||||||||||||
| # Optional: build the OpenCode embed (live coding UI in the Workers tab) | ||||||||||||||
| # Requires Node 22+ (use fnm: fnm install v24.14.0 && fnm use v24.14.0) | ||||||||||||||
| ./scripts/build-opencode-embed.sh | ||||||||||||||
|
Comment on lines
+431
to
+433
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. “Optional” step is currently executed in the pasted command block Line 431 labels this step optional, but Line 433 runs it unconditionally if users copy/paste the block. Comment out the command or move it to a separate optional block. Suggested doc tweak # Optional: build the OpenCode embed (live coding UI in the Workers tab)
# Requires Node 22+ (use fnm: fnm install v24.14.0 && fnm use v24.14.0)
-./scripts/build-opencode-embed.sh
+# ./scripts/build-opencode-embed.sh📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||
|
|
||||||||||||||
| # Install the binary | ||||||||||||||
| cargo install --path . | ||||||||||||||
| ``` | ||||||||||||||
|
|
||||||||||||||
| ### Minimal Config | ||||||||||||||
|
|
||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid mixing
npm iintointerface/quickstart flowIncluding
npm iin the default quickstart contradicts the repo’s bun-only frontend package-management policy and may introduce lockfile drift/confusing state for contributors. Keep the default path bun-only, and if needed, document npm as a clearly labeled last-resort troubleshooting step.Based on learnings: “Use
bunfor all JavaScript/TypeScript package management and scripts inspacebot/interface/. Never usenpm,pnpm, oryarnunless explicitly requested by the user.”🤖 Prompt for AI Agents
🧩 Analysis chain
🏁 Script executed:
Repository: spacedriveapp/spacebot
Length of output: 176
Remove
npm iand usebun run buildinstead ofbun buildThe command uses
npm(violates the bun-only policy forinterface/) andbun build(incorrect for a Vite-based build). The corrected command should be:This invokes the
vite buildscript frompackage.jsonand adheres to the project's package manager policy.🤖 Prompt for AI Agents