medtak#4532
Open
Fooksy2304 wants to merge 5 commits into
Open
Conversation
Contributor
|
RSI Diff Bot; head commit f0c36c0 merging into d9a16de Resources/Textures/_Sunrise/Admeme/Clothing/Back/Backpacks/medtak.rsi
Resources/Textures/_Sunrise/Admeme/Clothing/Belt/medtak_belt.rsi
Resources/Textures/_Sunrise/Admeme/Clothing/Ears/Headsets/medtak.rsi
Resources/Textures/_Sunrise/Admeme/Clothing/Eyes/Hud/medtak.rsi
Resources/Textures/_Sunrise/Admeme/Clothing/Head/Hardsuits/medtak_helmet.rsi
Resources/Textures/_Sunrise/Admeme/Clothing/Head/Hardsuits/medtak_leader_helmet.rsi
Resources/Textures/_Sunrise/Admeme/Clothing/OuterClothing/Hardsuits/medtak_hardsuit.rsi
Resources/Textures/_Sunrise/Admeme/Mobs/Silicon/Chassis/medtak.rsi
Resources/Textures/_Sunrise/Admeme/Objects/MedTak/bed.rsi
Resources/Textures/_Sunrise/Admeme/Objects/MedTak/bodybag.rsi
Resources/Textures/_Sunrise/Admeme/Objects/MedTak/medkit.rsi
Resources/Textures/_Sunrise/Admeme/Weapons/MedTak/CyborgRifle.rsi
Resources/Textures/_Sunrise/Admeme/Weapons/MedTak/Hammer.rsi
Resources/Textures/_Sunrise/Admeme/Weapons/MedTak/LMG.rsi
Resources/Textures/_Sunrise/Admeme/Weapons/MedTak/Pistol.rsi
Resources/Textures/_Sunrise/Admeme/Weapons/MedTak/Rifle.rsi
Resources/Textures/_Sunrise/Admeme/hoverbed.rsi
Resources/Textures/_Sunrise/Clothing/Neck/tsfdetective.rsi
Resources/Textures/_Sunrise/Clothing/OuterClothing/Coats/tsfarmor.rsi
Resources/Textures/_Sunrise/Clothing/Uniforms/Jumpsuit/tsfanother_suit.rsi
Resources/Textures/_Sunrise/Interface/Actions/actions_borg.rsi
Resources/Textures/_Sunrise/Interface/Misc/job_icons.rsi
Resources/Textures/_Sunrise/Objects/Devices/encryption_keys.rsi
Resources/Textures/_Sunrise/Objects/Devices/pda.rsi
Resources/Textures/_Sunrise/Objects/Misc/id_cards.rsi
Resources/Textures/_Sunrise/Objects/Specific/Robotics/borgmodule.rsi
Resources/Textures/_Sunrise/Structures/Storage/Shelfs/medtak.rsi
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughPR добавляет полную фракцию MedTak и расширяет TSF. MedTak содержит системные настройки (доступ, радиоканал, теги, контрабанда), новую экипировку (скафандры, рюкзаки, пояса, визоры, каталки, stasis-кровать), оружейную линейку (LMG, rifle, borg-rifle, pistol, молоты), кибер-платформу с двумя модулями и законами, ролевые наполнения операторов, карту шаттла AV-40 и полную двуязычную локализацию (EN/RU). TSF получает новую боевую экипировку маршала. ChangesФракция MedTak
Расширение TSF
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 16
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (8)
Resources/Locale/ru-RU/_strings/_sunrise/medtak/laws.ftl (1)
1-6: 🧹 Nitpick | 🔵 Trivial | ⚡ Quick winДобавьте завершающий перевод строки в конец файла.
Файл заканчивается на строке 6 без финального символа новой строки.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Resources/Locale/ru-RU/_strings/_sunrise/medtak/laws.ftl` around lines 1 - 6, The file is missing a final newline character at the end. After the last line containing laws-owner-medtak = Персонал МедТак, add a newline character to properly terminate the file according to standard file formatting conventions.Resources/Locale/en-US/_prototypes/_sunrise/medtak/entities.ftl (1)
1-117: 🧹 Nitpick | 🔵 Trivial | ⚡ Quick winДобавьте завершающий перевод строки в конец файла.
Файл заканчивается на строке 117 без финального символа новой строки. Это может вызвать предупреждения в некоторых инструментах и не соответствует POSIX-стандарту для текстовых файлов.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Resources/Locale/en-US/_prototypes/_sunrise/medtak/entities.ftl` around lines 1 - 117, The file is missing a final newline character at the end, which doesn't comply with POSIX standards for text files and may cause warnings in some tools. Add a newline character at the very end of the file after the last entity definition (ent-WindoorSecureMedTakLocked).Resources/Locale/en-US/_strings/_sunrise/medtak/laws.ftl (1)
1-6: 🧹 Nitpick | 🔵 Trivial | ⚡ Quick winДобавьте завершающий перевод строки в конец файла.
Файл заканчивается на строке 6 без финального символа новой строки.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Resources/Locale/en-US/_strings/_sunrise/medtak/laws.ftl` around lines 1 - 6, The file ends without a trailing newline character at the end. Add a newline character after the last line (laws-owner-medtak = MedTak personnel) to ensure the file properly terminates with a newline as is standard practice for text files.Resources/Locale/ru-RU/_strings/_sunrise/medtak/silicons.ftl (1)
1-5: 🧹 Nitpick | 🔵 Trivial | ⚡ Quick winДобавьте завершающий перевод строки в конец файла.
Файл заканчивается на строке 5 без финального символа новой строки.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Resources/Locale/ru-RU/_strings/_sunrise/medtak/silicons.ftl` around lines 1 - 5, The file is missing a newline character at the end. After the last line containing borg-slot-syringe-empty definition, add a newline character to properly terminate the file. This follows the standard convention that text files should end with a newline character.Resources/Locale/en-US/_strings/_sunrise/medtak/silicons.ftl (1)
1-5: 🧹 Nitpick | 🔵 Trivial | ⚡ Quick winДобавьте завершающий перевод строки в конец файла.
Файл заканчивается на строке 5 без финального символа новой строки.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Resources/Locale/en-US/_strings/_sunrise/medtak/silicons.ftl` around lines 1 - 5, The file Resources/Locale/en-US/_strings/_sunrise/medtak/silicons.ftl is missing a newline character at the end. Add a final newline after the last line (borg-slot-syringe-empty = Syringes and injectors) to ensure the file properly terminates with a newline character as is standard for text files.Resources/Locale/en-US/_strings/_sunrise/medtak/job.ftl (1)
1-7: 🧹 Nitpick | 🔵 Trivial | ⚡ Quick winДобавьте завершающий перевод строки в конец файла.
Файл заканчивается на строке 7 без финального символа новой строки.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Resources/Locale/en-US/_strings/_sunrise/medtak/job.ftl` around lines 1 - 7, The file is missing a trailing newline character at the end. After the last job definition (job-name-medtak-borg = MedTak Silicon), add a newline character to ensure the file ends with a proper line terminator, following standard text file conventions.Resources/Locale/ru-RU/_strings/_sunrise/medtak/job.ftl (1)
1-7: 🧹 Nitpick | 🔵 Trivial | ⚡ Quick winДобавьте завершающий перевод строки в конец файла.
Файл заканчивается на строке 7 без финального символа новой строки.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Resources/Locale/ru-RU/_strings/_sunrise/medtak/job.ftl` around lines 1 - 7, The file is missing a trailing newline character at the end. After the last job translation entry (job-name-medtak-borg = Кремний МедТак), add a newline character to properly terminate the file. This ensures the file ends with a newline character as per standard file formatting conventions.Resources/Locale/ru-RU/_prototypes/_sunrise/medtak/entities.ftl (1)
1-117: 🧹 Nitpick | 🔵 Trivial | ⚡ Quick winДобавьте завершающий перевод строки в конец файла.
Файл заканчивается на строке 117 без финального символа новой строки, как и английская версия. Это может вызвать предупреждения в некоторых инструментах.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Resources/Locale/ru-RU/_prototypes/_sunrise/medtak/entities.ftl` around lines 1 - 117, The Russian locale file is missing a newline character at the end, which can trigger warnings in some tools. Add a newline character at the very end of the file after the last entity definition (ent-WindoorSecureMedTakLocked and its content) to ensure the file properly terminates with a newline, matching standard file formatting conventions.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Resources/Audio/_Sunrise/Weapons/Guns/Gunshots/attributions.yml`:
- Around line 1-3: The attribution entry for code-6.ogg is missing a required
`source` field, which causes the RGA schema validation to fail and blocks the
build. Add a `source` field to the attribution record in the attributions.yml
file that contains the actual source URL or location of this audio file from
ss14Starlight. The source field must be present alongside the existing files,
license, and copyright fields for the validation to pass.
In `@Resources/Locale/ru-RU/_strings/_sunrise/headset/headset-component.ftl`:
- Around line 9-10: The word order in the chat-radio-medtak-borg translation is
inverted and inconsistent with the existing naming pattern used throughout the
codebase. Change the translation from кремний МедТак to МедТак кремний to match
the established convention where the proper noun (МедТак) appears before the
descriptor, consistent with similar compound borg-type names in the locale file.
In `@Resources/Maps/_Sunrise/Shuttles/MedTak-AV-40.yml`:
- Line 1: The YAML file MedTak-AV-40.yml violates the required snake_case naming
convention for YAML files. Rename this file to use snake_case format (such as
med_tak_av_40.yml) and search the codebase to find and update all references to
the old file name wherever this map is included or referenced, ensuring
consistency across all configuration files and map inclusion statements.
In `@Resources/Prototypes/_Sunrise/Admeme/Entities/Clothing/Belt/belts.yml`:
- Line 8: The comment `#Starlight` attached to the Storage type on line 8 lacks
clarity and context. Either provide a clear explanation of what `#Starlight`
refers to (such as a reference to another fork, system, or specific requirement)
by updating the comment to be descriptive, or remove the comment entirely if it
is outdated and no longer relevant to the codebase.
In
`@Resources/Prototypes/_Sunrise/Admeme/Entities/Clothing/OuterClothing/hardsuits.yml`:
- Around line 47-48: The ClothingOuterHardsuitMedTakLeader prototype contains a
ToggleableClothing component declaration with clothingPrototype set to
ClothingHeadHelmetHardsuitMedical, which duplicates the base hardsuit's helmet
configuration. Either remove this redundant ToggleableClothing override from
ClothingOuterHardsuitMedTakLeader if the leader helmet should be identical to
the base hardsuit, or create a separate distinctive helmet prototype and
reference it here if the leader should have a unique helmet with additional
visual elements.
- Around line 13-14: The MedTak hardsuits are currently using the generic
vanilla medical helmet reference `ClothingHeadHelmetHardsuitMedical` instead of
a specialized variant. To maintain consistency with other specialized hardsuits
in the codebase that have their own helmet variants (such as
`ClothingHeadHelmetHardsuitBlueshield` and `ClothingHeadHelmetHardsuitNTRG`),
either create a new specialized helmet prototype
`ClothingHeadHelmetHardsuitMedTak` and update the clothingPrototype reference in
the ToggleableClothing entries for both the operator and leader MedTak hardsuits
to point to this new helmet, or explicitly document that using the vanilla
medical helmet is an intentional design choice.
In `@Resources/Prototypes/_Sunrise/Admeme/Entities/Objects/MedTak/hoverbed.yml`:
- Around line 18-20: The heldPrefix field in the Item component is empty with no
value assigned, which can cause unexpected sprite rendering behavior when the
item is held. Either remove the heldPrefix line entirely if no held sprite
prefix is needed for this item, or provide a valid string value to the
heldPrefix field (such as "hover") if one is required for rendering the correct
sprite variant in the character's hands. Ensure the field either has a concrete
string value or is removed completely from the component definition.
In `@Resources/Prototypes/_Sunrise/Admeme/Entities/Weapons/hammer.yml`:
- Around line 91-93: The ItemToggle component in the hammer definition has both
onUse and onActivate disabled, which prevents players from toggling the weapon's
mode through standard interaction methods. Enable at least one of these toggle
options (either set onUse: true or onActivate: true) to allow the
ItemToggleMeleeWeapon functionality to work for players. If an alternative
toggle mechanism like a custom verb is intended, verify it exists and is
properly configured in the weapon definition.
In `@Resources/Prototypes/_Sunrise/Admeme/Entities/Weapons/medtak.yml`:
- Around line 113-157: The entity WeaponRifleMedTakROW inherits from BaseItem
instead of BaseWeaponRifle, which is atypical for a weapon. Clarify the design
intent by either changing the parent to BaseWeaponRifle if this should follow
standard weapon inheritance, or if BaseItem is intentional for the cyborg
variant, verify that all necessary weapon components normally provided by
BaseWeaponRifle (such as ChamberMagazineAmmoProvider and other base components)
are explicitly included in the components list or are not required due to the
BallisticAmmoProvider and BallisticAmmoSelfRefiller implementation. Ensure this
architectural choice is deliberate and documented.
- Around line 36-48: Fix the cartridge type mismatch in the medtak.yml weapon
configuration. The gun_magazine slot currently uses MagazineRifleHeavySP which
contains heavy cartridges, but the gun_chamber slot specifies
CartridgeLightRifleSP which are incompatible light cartridges. Either replace
the startingItem in the gun_magazine slot with MagazineRifleLightSP to match the
light cartridges expected by gun_chamber, or replace the startingItem in
gun_chamber with CartridgeRifleHeavySP and update its whitelist tag to
CartridgeRifleHeavy to match the heavy cartridges from the magazine.
- Around line 179-189: The medtak.yml weapon configuration references whitelist
tags `MagazinePistolDP` and `CartridgePistolDP` that are not defined in the
_Sunrise fork's tags.yml file, only existing in _Starlight. According to fork
development principles, either add these missing tag definitions to
Resources/Prototypes/_Sunrise/tags.yml to ensure they are available in the
_Sunrise fork, or replace the whitelist tag references in the medtak.yml file
(in both the gun_magazine_slot whitelist and gun_chamber whitelist sections)
with existing tags that are already defined in _Sunrise. Similarly, verify that
the starting items CartridgePistol40SP and MagazinePistol40SP are properly
available in _Sunrise or adjust them to use items that exist in the fork.
In `@Resources/Prototypes/_Sunrise/Admeme/Fills/belt.yml`:
- Around line 7-19: The new MedTak belt prototypes referenced in the belt.yml
file are missing their localization entries. Add the following four localization
keys to both Resources/Locale/en-US/_prototypes/_sunrise/medtak/entities.ftl and
Resources/Locale/ru-RU/_prototypes/_sunrise/medtak/entities.ftl files:
ent-ClothingBeltMedTakFilledHeavy with a description matching the "Filled,
Security, Heavy" suffix context, ent-ClothingBeltMedTakFilledRifle with a
description for the "Filled, Security, Rifle" suffix context,
ent-ClothingBeltMedTakFilledMedic with a description for the "Filled, Medic"
suffix context, and ent-ClothingBeltMedTakFilledPilot with a description for the
"Filled, Pilot" suffix context. Ensure both locale files contain all four keys
with appropriate translations for their respective languages.
In `@Resources/Prototypes/_Sunrise/Admeme/Fills/shelf.yml`:
- Around line 1-31: The children list in the EntityTableContainerFill component
contains duplicate item IDs: ChemistryBottlePyrazine, ChemistryBottleOmnizine,
and EmergencyMedipen each appear twice. Remove all duplicate entries from the
children array so each item ID is listed only once. If the intention is to
include multiple instances of certain items, use the amount field for each item
instead of repeating the ID multiple times, following the pattern used in
similar shelf definitions.
In `@Resources/Prototypes/_Sunrise/Entities/Objects/Misc/paper.yml`:
- Around line 52-78: Remove the Sunrise-specific comment markers from this file
since it is already located in the Resources/Prototypes/_Sunrise/ directory.
Delete the comment lines "# Sunrise added start - бланк счёта MedTak" and "#
Sunrise added end" while keeping the entity definition for PaperMedTak intact.
The directory path itself already indicates this is Sunrise-owned code, so these
markers are redundant per the coding guidelines.
In `@Resources/Prototypes/_Sunrise/radio_channels.yml`:
- Around line 64-72: Remove the Sunrise-specific marker comments (# Sunrise
added start and # Sunrise added end) from both affected files as they are not
used in the _Sunrise directory structure. In
Resources/Prototypes/_Sunrise/radio_channels.yml at lines 64-72, replace the
Russian comment with an English one such as # MedTak radio channel. Apply the
same fix in Resources/Prototypes/_Sunrise/tags.yml at lines 728-734 by removing
the Sunrise markers and replacing any non-English comments with English
documentation. All YAML documentation in the _Sunrise prototype directory must
follow English-only conventions without Sunrise-specific tracking markers.
In `@Resources/Textures/_Sunrise/Interface/Misc/job_icons.rsi/meta.json`:
- Around line 133-153: The state name `MedTak_Mindshield` is inconsistent with
the naming convention used by all other MedTak states (MedTakLeader,
MedTakDispatcher, MedTakMedic, MedTakPilot, MedTakSecurity, MedTakBorg), which
use pure CamelCase without underscores. Rename `MedTak_Mindshield` to
`MedTakMindshield` in the current file to match the CamelCase pattern.
Additionally, update any references to this state name in other files (such as
the security.yml file mentioned in the comment) to use the new
`MedTakMindshield` name to maintain consistency across the codebase.
---
Outside diff comments:
In `@Resources/Locale/en-US/_prototypes/_sunrise/medtak/entities.ftl`:
- Around line 1-117: The file is missing a final newline character at the end,
which doesn't comply with POSIX standards for text files and may cause warnings
in some tools. Add a newline character at the very end of the file after the
last entity definition (ent-WindoorSecureMedTakLocked).
In `@Resources/Locale/en-US/_strings/_sunrise/medtak/job.ftl`:
- Around line 1-7: The file is missing a trailing newline character at the end.
After the last job definition (job-name-medtak-borg = MedTak Silicon), add a
newline character to ensure the file ends with a proper line terminator,
following standard text file conventions.
In `@Resources/Locale/en-US/_strings/_sunrise/medtak/laws.ftl`:
- Around line 1-6: The file ends without a trailing newline character at the
end. Add a newline character after the last line (laws-owner-medtak = MedTak
personnel) to ensure the file properly terminates with a newline as is standard
practice for text files.
In `@Resources/Locale/en-US/_strings/_sunrise/medtak/silicons.ftl`:
- Around line 1-5: The file
Resources/Locale/en-US/_strings/_sunrise/medtak/silicons.ftl is missing a
newline character at the end. Add a final newline after the last line
(borg-slot-syringe-empty = Syringes and injectors) to ensure the file properly
terminates with a newline character as is standard for text files.
In `@Resources/Locale/ru-RU/_prototypes/_sunrise/medtak/entities.ftl`:
- Around line 1-117: The Russian locale file is missing a newline character at
the end, which can trigger warnings in some tools. Add a newline character at
the very end of the file after the last entity definition
(ent-WindoorSecureMedTakLocked and its content) to ensure the file properly
terminates with a newline, matching standard file formatting conventions.
In `@Resources/Locale/ru-RU/_strings/_sunrise/medtak/job.ftl`:
- Around line 1-7: The file is missing a trailing newline character at the end.
After the last job translation entry (job-name-medtak-borg = Кремний МедТак),
add a newline character to properly terminate the file. This ensures the file
ends with a newline character as per standard file formatting conventions.
In `@Resources/Locale/ru-RU/_strings/_sunrise/medtak/laws.ftl`:
- Around line 1-6: The file is missing a final newline character at the end.
After the last line containing laws-owner-medtak = Персонал МедТак, add a
newline character to properly terminate the file according to standard file
formatting conventions.
In `@Resources/Locale/ru-RU/_strings/_sunrise/medtak/silicons.ftl`:
- Around line 1-5: The file is missing a newline character at the end. After the
last line containing borg-slot-syringe-empty definition, add a newline character
to properly terminate the file. This follows the standard convention that text
files should end with a newline character.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 0b90083d-8cc0-4e2d-aa54-7b015f370665
⛔ Files ignored due to path filters (127)
Resources/Audio/_Sunrise/Weapons/Guns/Gunshots/code-6.oggis excluded by!**/*.oggResources/Textures/_Sunrise/Admeme/Clothing/Back/Backpacks/medtak.rsi/equipped-BACKPACK.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Clothing/Back/Backpacks/medtak.rsi/icon.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Clothing/Back/Backpacks/medtak.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Clothing/Back/Backpacks/medtak.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Clothing/Belt/medtak_belt.rsi/equipped-BELT.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Clothing/Belt/medtak_belt.rsi/icon.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Clothing/Belt/medtak_belt.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Clothing/Belt/medtak_belt.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Clothing/Ears/Headsets/medtak.rsi/alt-equipped-EARS.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Clothing/Ears/Headsets/medtak.rsi/icon_alt.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Clothing/Eyes/Hud/medtak.rsi/equipped-EYES.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Clothing/Eyes/Hud/medtak.rsi/icon.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Clothing/OuterClothing/Hardsuits/medtak_hardsuit.rsi/equipped-OUTERCLOTHING-avali.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Clothing/OuterClothing/Hardsuits/medtak_hardsuit.rsi/equipped-OUTERCLOTHING-reptilian.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Clothing/OuterClothing/Hardsuits/medtak_hardsuit.rsi/equipped-OUTERCLOTHING.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Clothing/OuterClothing/Hardsuits/medtak_hardsuit.rsi/icon.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Clothing/OuterClothing/Hardsuits/medtak_hardsuit.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Clothing/OuterClothing/Hardsuits/medtak_hardsuit.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Mobs/Silicon/Chassis/medtak.rsi/borg.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Mobs/Silicon/Chassis/medtak.rsi/borg_e.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Mobs/Silicon/Chassis/medtak.rsi/borg_e_r.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Mobs/Silicon/Chassis/medtak.rsi/borg_l.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Objects/MedTak/bed.rsi/bed.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Objects/MedTak/bed.rsi/stasis.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Objects/MedTak/bodybag.rsi/bag-inhand-left.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Objects/MedTak/bodybag.rsi/bag-inhand-right.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Objects/MedTak/bodybag.rsi/bag.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Objects/MedTak/bodybag.rsi/bag_folded.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Objects/MedTak/bodybag.rsi/bounty.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Objects/MedTak/bodybag.rsi/captains_paper.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Objects/MedTak/bodybag.rsi/invoice.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Objects/MedTak/bodybag.rsi/locked.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Objects/MedTak/bodybag.rsi/open_overlay.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Objects/MedTak/bodybag.rsi/paper.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Objects/MedTak/bodybag.rsi/unlocked.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Objects/MedTak/medkit.rsi/medkit.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Objects/MedTak/medkit.rsi/medtak-inhand-left.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Objects/MedTak/medkit.rsi/medtak-inhand-right.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/CyborgRifle.rsi/icon.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/CyborgRifle.rsi/mag-0.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/CyborgRifle.rsi/mag-1.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/CyborgRifle.rsi/mag-2.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/Hammer.rsi/equipped-BACKPACK.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/Hammer.rsi/equipped-SUITSTORAGE.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/Hammer.rsi/icon-active.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/Hammer.rsi/icon.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/Hammer.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/Hammer.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/Hammer.rsi/wielded-inhand-left.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/Hammer.rsi/wielded-inhand-right.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/LMG.rsi/base.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/LMG.rsi/bolt-open.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/LMG.rsi/equipped-BACKPACK.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/LMG.rsi/equipped-SUITSTORAGE.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/LMG.rsi/icon.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/LMG.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/LMG.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/LMG.rsi/mag-0.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/LMG.rsi/mag-1.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/LMG.rsi/mag-2.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/LMG.rsi/mag-3.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/LMG.rsi/mag-4.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/LMG.rsi/mag-5.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/LMG.rsi/wielded-inhand-left.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/LMG.rsi/wielded-inhand-right.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/Pistol.rsi/base.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/Pistol.rsi/bolt-open.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/Pistol.rsi/icon.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/Pistol.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/Pistol.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/Pistol.rsi/mag-0.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/Rifle.rsi/base.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/Rifle.rsi/bolt-open.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/Rifle.rsi/equipped-BACKPACK.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/Rifle.rsi/equipped-SUITSTORAGE.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/Rifle.rsi/icon.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/Rifle.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/Rifle.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/Rifle.rsi/mag-0.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/Rifle.rsi/mag-1.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/Rifle.rsi/mag-2.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/Rifle.rsi/mag-3.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/Rifle.rsi/wielded-inhand-left.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Weapons/MedTak/Rifle.rsi/wielded-inhand-right.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/hoverbed.rsi/hover_buckled.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/hoverbed.rsi/hover_folded.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/hoverbed.rsi/hover_unfolded.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/hoverbed.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/hoverbed.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Interface/Actions/actions_borg.rsi/medtak-aid-module.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Interface/Actions/actions_borg.rsi/medtak-combat-module.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Interface/Misc/job_icons.rsi/MedTakBorg.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Interface/Misc/job_icons.rsi/MedTakDispatcher.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Interface/Misc/job_icons.rsi/MedTakLeader.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Interface/Misc/job_icons.rsi/MedTakMedic.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Interface/Misc/job_icons.rsi/MedTakPilot.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Interface/Misc/job_icons.rsi/MedTakSecurity.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Interface/Misc/job_icons.rsi/MedTak_Mindshield.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Interface/Paper/MedTak.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Objects/Devices/encryption_keys.rsi/crypt_medtak.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Objects/Devices/encryption_keys.rsi/medtak_label.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Objects/Devices/pda.rsi/pda-medtak.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Objects/Misc/id_cards.rsi/medtak.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Objects/Specific/Robotics/borgmodule.rsi/base-icon-inhand-left.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Objects/Specific/Robotics/borgmodule.rsi/base-icon-inhand-right.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Objects/Specific/Robotics/borgmodule.rsi/base-module-inhand-left.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Objects/Specific/Robotics/borgmodule.rsi/base-module-inhand-right.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Objects/Specific/Robotics/borgmodule.rsi/base-part-inhand-left.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Objects/Specific/Robotics/borgmodule.rsi/base-part-inhand-right.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Objects/Specific/Robotics/borgmodule.rsi/base-stripes-inhand-left.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Objects/Specific/Robotics/borgmodule.rsi/base-stripes-inhand-right.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Objects/Specific/Robotics/borgmodule.rsi/icon-medtak-med.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Objects/Specific/Robotics/borgmodule.rsi/icon-medtak-sec.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Objects/Specific/Robotics/borgmodule.rsi/medtak.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Structures/Storage/Shelfs/medtak.rsi/base.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Structures/Storage/Shelfs/medtak.rsi/chem-0.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Structures/Storage/Shelfs/medtak.rsi/chem-1.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Structures/Storage/Shelfs/medtak.rsi/chem-2.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Structures/Storage/Shelfs/medtak.rsi/chem-3.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Structures/Storage/Shelfs/medtak.rsi/chem-4.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Structures/Storage/Shelfs/medtak.rsi/chem-5.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Structures/Storage/Shelfs/medtak.rsi/chem-6.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Structures/Storage/Shelfs/medtak.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Structures/Storage/Shelfs/medtak.rsi/locked.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Structures/Storage/Shelfs/medtak.rsi/open.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Structures/Storage/Shelfs/medtak.rsi/unlocked.pngis excluded by!**/*.png
📒 Files selected for processing (78)
Resources/Audio/_Sunrise/Weapons/Guns/Gunshots/attributions.ymlResources/Locale/en-US/_prototypes/_sunrise/medtak/entities.ftlResources/Locale/en-US/_strings/_sunrise/headset/headset-component.ftlResources/Locale/en-US/_strings/_sunrise/medtak/accesses.ftlResources/Locale/en-US/_strings/_sunrise/medtak/contraband-severity.ftlResources/Locale/en-US/_strings/_sunrise/medtak/job.ftlResources/Locale/en-US/_strings/_sunrise/medtak/laws.ftlResources/Locale/en-US/_strings/_sunrise/medtak/silicons.ftlResources/Locale/ru-RU/_prototypes/_sunrise/medtak/entities.ftlResources/Locale/ru-RU/_strings/_sunrise/headset/headset-component.ftlResources/Locale/ru-RU/_strings/_sunrise/medtak/accesses.ftlResources/Locale/ru-RU/_strings/_sunrise/medtak/contraband-severity.ftlResources/Locale/ru-RU/_strings/_sunrise/medtak/job.ftlResources/Locale/ru-RU/_strings/_sunrise/medtak/laws.ftlResources/Locale/ru-RU/_strings/_sunrise/medtak/silicons.ftlResources/Maps/_Sunrise/Shuttles/MedTak-AV-40.ymlResources/Prototypes/_Sunrise/Access/misc.ymlResources/Prototypes/_Sunrise/Admeme/Entities/Clothing/Back/backpacks.ymlResources/Prototypes/_Sunrise/Admeme/Entities/Clothing/Belt/belts.ymlResources/Prototypes/_Sunrise/Admeme/Entities/Clothing/Eyes/hud.ymlResources/Prototypes/_Sunrise/Admeme/Entities/Clothing/OuterClothing/hardsuits.ymlResources/Prototypes/_Sunrise/Admeme/Entities/Objects/MedTak/bed.ymlResources/Prototypes/_Sunrise/Admeme/Entities/Objects/MedTak/bodybag.ymlResources/Prototypes/_Sunrise/Admeme/Entities/Objects/MedTak/hoverbed.ymlResources/Prototypes/_Sunrise/Admeme/Entities/Objects/MedTak/kits.ymlResources/Prototypes/_Sunrise/Admeme/Entities/Weapons/hammer.ymlResources/Prototypes/_Sunrise/Admeme/Entities/Weapons/medtak.ymlResources/Prototypes/_Sunrise/Admeme/Fills/backpack.ymlResources/Prototypes/_Sunrise/Admeme/Fills/belt.ymlResources/Prototypes/_Sunrise/Admeme/Fills/kits.ymlResources/Prototypes/_Sunrise/Admeme/Fills/shelf.ymlResources/Prototypes/_Sunrise/Entities/Clothing/Ears/headsets_alt.ymlResources/Prototypes/_Sunrise/Entities/Objects/Devices/encryption_keys.ymlResources/Prototypes/_Sunrise/Entities/Objects/Misc/paper.ymlResources/Prototypes/_Sunrise/Entities/Structures/Doors/Windoors/windoor.ymlResources/Prototypes/_Sunrise/Entities/Structures/Wallmounts/Storage/shelfs.ymlResources/Prototypes/_Sunrise/MedTak/airlocks.ymlResources/Prototypes/_Sunrise/MedTak/base_contraband.ymlResources/Prototypes/_Sunrise/MedTak/borg_chassis.ymlResources/Prototypes/_Sunrise/MedTak/borg_modules.ymlResources/Prototypes/_Sunrise/MedTak/door_access.ymlResources/Prototypes/_Sunrise/MedTak/identification_cards.ymlResources/Prototypes/_Sunrise/MedTak/implanters.ymlResources/Prototypes/_Sunrise/MedTak/pda.ymlResources/Prototypes/_Sunrise/MedTak/rubber_stamp.ymlResources/Prototypes/_Sunrise/MedTak/silicon.ymlResources/Prototypes/_Sunrise/MedTak/silicon_laws.ymlResources/Prototypes/_Sunrise/MedTak/subdermal_implants.ymlResources/Prototypes/_Sunrise/MedTak/wire_layouts.ymlResources/Prototypes/_Sunrise/Roles/Jobs/MedTak/operators.ymlResources/Prototypes/_Sunrise/StatusIcon/job.ymlResources/Prototypes/_Sunrise/StatusIcon/security.ymlResources/Prototypes/_Sunrise/contraband_severities.ymlResources/Prototypes/_Sunrise/radio_channels.ymlResources/Prototypes/_Sunrise/tags.ymlResources/Textures/_Sunrise/Admeme/Clothing/Back/Backpacks/medtak.rsi/meta.jsonResources/Textures/_Sunrise/Admeme/Clothing/Belt/medtak_belt.rsi/meta.jsonResources/Textures/_Sunrise/Admeme/Clothing/Ears/Headsets/medtak.rsi/meta.jsonResources/Textures/_Sunrise/Admeme/Clothing/Eyes/Hud/medtak.rsi/meta.jsonResources/Textures/_Sunrise/Admeme/Clothing/OuterClothing/Hardsuits/medtak_hardsuit.rsi/meta.jsonResources/Textures/_Sunrise/Admeme/Mobs/Silicon/Chassis/medtak.rsi/meta.jsonResources/Textures/_Sunrise/Admeme/Objects/MedTak/bed.rsi/meta.jsonResources/Textures/_Sunrise/Admeme/Objects/MedTak/bodybag.rsi/meta.jsonResources/Textures/_Sunrise/Admeme/Objects/MedTak/cases.rsi/meta.jsonResources/Textures/_Sunrise/Admeme/Objects/MedTak/medkit.rsi/meta.jsonResources/Textures/_Sunrise/Admeme/Weapons/MedTak/CyborgRifle.rsi/meta.jsonResources/Textures/_Sunrise/Admeme/Weapons/MedTak/Hammer.rsi/meta.jsonResources/Textures/_Sunrise/Admeme/Weapons/MedTak/LMG.rsi/meta.jsonResources/Textures/_Sunrise/Admeme/Weapons/MedTak/Pistol.rsi/meta.jsonResources/Textures/_Sunrise/Admeme/Weapons/MedTak/Rifle.rsi/meta.jsonResources/Textures/_Sunrise/Admeme/hoverbed.rsi/meta.jsonResources/Textures/_Sunrise/Interface/Actions/actions_borg.rsi/meta.jsonResources/Textures/_Sunrise/Interface/Misc/job_icons.rsi/meta.jsonResources/Textures/_Sunrise/Objects/Devices/encryption_keys.rsi/meta.jsonResources/Textures/_Sunrise/Objects/Devices/pda.rsi/meta.jsonResources/Textures/_Sunrise/Objects/Misc/id_cards.rsi/meta.jsonResources/Textures/_Sunrise/Objects/Specific/Robotics/borgmodule.rsi/meta.jsonResources/Textures/_Sunrise/Structures/Storage/Shelfs/medtak.rsi/meta.json
Contributor
Author
|
перекур |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Resources/Locale/ru-RU/_prototypes/_sunrise/entities/tsf.ftl`:
- Around line 28-29: The Russian description for
ent-ClothingUniformEventJumpsuitTSF currently refers to it as a general TSF
employee uniform ("сотрудника ТСФ") but loses the marshal-specific role
indicated in the entity name and English version. Update the .desc property to
clarify that this uniform is specifically for marshals, aligning the Russian
localization with the English intent by specifying that it is issued to or worn
by marshals rather than describing it as a general employee uniform.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 02396f48-5ea9-49b1-88d1-baebba1aaf4d
⛔ Files ignored due to path filters (12)
Resources/Textures/_Sunrise/Clothing/Neck/tsfdetective.rsi/equipped-NECK.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Clothing/Neck/tsfdetective.rsi/icon.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Clothing/Neck/tsfdetective.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Clothing/Neck/tsfdetective.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Clothing/OuterClothing/Coats/tsfarmor.rsi/equipped-OUTERCLOTHING.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Clothing/OuterClothing/Coats/tsfarmor.rsi/icon.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Clothing/OuterClothing/Coats/tsfarmor.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Clothing/OuterClothing/Coats/tsfarmor.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Clothing/Uniforms/Jumpsuit/tsfanother_suit.rsi/equipped-INNERCLOTHING.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Clothing/Uniforms/Jumpsuit/tsfanother_suit.rsi/icon.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Clothing/Uniforms/Jumpsuit/tsfanother_suit.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Clothing/Uniforms/Jumpsuit/tsfanother_suit.rsi/inhand-right.pngis excluded by!**/*.png
📒 Files selected for processing (8)
Resources/Locale/en-US/_prototypes/_sunrise/entities/tsf.ftlResources/Locale/ru-RU/_prototypes/_sunrise/entities/tsf.ftlResources/Prototypes/_Sunrise/Entities/Clothing/Neck/cloaks.ymlResources/Prototypes/_Sunrise/Entities/Clothing/OuterClothing/softsuits.ymlResources/Prototypes/_Sunrise/Entities/Clothing/Uniforms/jumpsuits.ymlResources/Textures/_Sunrise/Clothing/Neck/tsfdetective.rsi/meta.jsonResources/Textures/_Sunrise/Clothing/OuterClothing/Coats/tsfarmor.rsi/meta.jsonResources/Textures/_Sunrise/Clothing/Uniforms/Jumpsuit/tsfanother_suit.rsi/meta.json
Contributor
Author
coderabbitai
Bot
added
🗺️ Карты 🗺️
🔊 Аудио 🔊
and removed
🧊 Нет C# 🧊
🖌️ Спрайты 🖌️
📚 Изменения: Локализация 📚
📦 YAML | Прототип 📦
labels
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@Resources/Prototypes/_Sunrise/Admeme/Entities/Clothing/OuterClothing/hardsuits.yml`:
- Around line 3-5: The YAML prototype file modifications in hardsuits.yml need
to be validated using the Content.YAMLLinter tool before merging. Run
Content.YAMLLinter against the modified YAML prototype files to ensure they
comply with all coding standards and guidelines, then provide the execution
artifacts confirming successful validation. While the manual review shows
correct CamelCase formatting for the ClothingHeadHelmetHardsuitMedTak entity ID
and proper component structure, the automated linting check is a mandatory
requirement per the coding guide that must be documented with execution
evidence.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 70c556ad-5d41-4334-97c4-e13063504ce6
⛔ Files ignored due to path filters (11)
Resources/Textures/_Sunrise/Admeme/Clothing/Head/Hardsuits/medtak_helmet.rsi/equipped-HELMET.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Clothing/Head/Hardsuits/medtak_helmet.rsi/icon-flash.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Clothing/Head/Hardsuits/medtak_helmet.rsi/icon.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Clothing/Head/Hardsuits/medtak_helmet.rsi/off-equipped-HELMET.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Clothing/Head/Hardsuits/medtak_helmet.rsi/on-equipped-HELMET.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Clothing/Head/Hardsuits/medtak_leader_helmet.rsi/equipped-HELMET.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Clothing/Head/Hardsuits/medtak_leader_helmet.rsi/icon-flash.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Clothing/Head/Hardsuits/medtak_leader_helmet.rsi/icon.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Clothing/Head/Hardsuits/medtak_leader_helmet.rsi/off-equipped-HELMET.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Admeme/Clothing/Head/Hardsuits/medtak_leader_helmet.rsi/on-equipped-HELMET.pngis excluded by!**/*.pngResources/Textures/_Sunrise/Interface/Misc/job_icons.rsi/MedTakMindShield.pngis excluded by!**/*.png
📒 Files selected for processing (18)
Resources/Audio/_Sunrise/Weapons/Guns/Gunshots/attributions.ymlResources/Locale/en-US/_prototypes/_sunrise/medtak/entities.ftlResources/Locale/ru-RU/_prototypes/_sunrise/medtak/entities.ftlResources/Locale/ru-RU/_strings/_sunrise/headset/headset-component.ftlResources/Maps/_Sunrise/Shuttles/med_tak_av_40.ymlResources/Prototypes/_Sunrise/Admeme/Entities/Clothing/OuterClothing/hardsuits.ymlResources/Prototypes/_Sunrise/Admeme/Entities/Objects/MedTak/hoverbed.ymlResources/Prototypes/_Sunrise/Admeme/Entities/Weapons/medtak.ymlResources/Prototypes/_Sunrise/Admeme/Fills/belt.ymlResources/Prototypes/_Sunrise/Admeme/Fills/shelf.ymlResources/Prototypes/_Sunrise/Entities/Objects/Devices/encryption_keys.ymlResources/Prototypes/_Sunrise/Entities/Objects/Misc/paper.ymlResources/Prototypes/_Sunrise/StatusIcon/security.ymlResources/Prototypes/_Sunrise/radio_channels.ymlResources/Prototypes/_Sunrise/tags.ymlResources/Textures/_Sunrise/Admeme/Clothing/Head/Hardsuits/medtak_helmet.rsi/meta.jsonResources/Textures/_Sunrise/Admeme/Clothing/Head/Hardsuits/medtak_leader_helmet.rsi/meta.jsonResources/Textures/_Sunrise/Interface/Misc/job_icons.rsi/meta.json
💤 Files with no reviewable changes (2)
- Resources/Prototypes/_Sunrise/Admeme/Entities/Objects/MedTak/hoverbed.yml
- Resources/Maps/_Sunrise/Shuttles/med_tak_av_40.yml
Comment on lines
+3
to
+5
| - type: entity | ||
| parent: [ ClothingHeadHardsuitBase, ClothingHeadSuitWithLightBase, BaseMedTakContraband ] | ||
| id: ClothingHeadHelmetHardsuitMedTak |
Contributor
There was a problem hiding this comment.
🛠️ Refactor suggestion | 🟠 Major
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
dotnet build Content.YAMLLinter/Content.YAMLLinter.csproj --configuration Release --no-restore /m
dotnet run --project Content.YAMLLinter/Content.YAMLLinter.csproj --no-buildRepository: space-sunrise/sunrise-station
Length of output: 120
🏁 Script executed:
#!/bin/bash
# Check what YAML files are being modified in this PR
# and verify the one at hand has proper syntax
cd Resources/Prototypes/_Sunrise/Admeme/Entities/Clothing/OuterClothing
# Check if the hardsuits.yml file exists and inspect it
if [ -f hardsuits.yml ]; then
head -20 hardsuits.yml
fiRepository: space-sunrise/sunrise-station
Length of output: 737
Требуется прогон Content.YAMLLinter для YAML-прототипов.
При ручной проверке структура YAML соответствует требованиям (корректный CamelCase для ID, компоненты без суффикса Component, валидный синтаксис). Однако согласно руководству кодирования, запуск Content.YAMLLinter для изменения YAML-файлов — это обязательная проверка, которую необходимо подтвердить артефактами выполнения.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@Resources/Prototypes/_Sunrise/Admeme/Entities/Clothing/OuterClothing/hardsuits.yml`
around lines 3 - 5, The YAML prototype file modifications in hardsuits.yml need
to be validated using the Content.YAMLLinter tool before merging. Run
Content.YAMLLinter against the modified YAML prototype files to ensure they
comply with all coding standards and guidelines, then provide the execution
artifacts confirming successful validation. While the manual review shows
correct CamelCase formatting for the ClothingHeadHelmetHardsuitMedTak entity ID
and proper component structure, the automated linting check is a mandatory
requirement per the coding guide that must be documented with execution
evidence.
Source: Coding guidelines
coderabbitai
Bot
added
🖌️ Спрайты 🖌️
📚 Изменения: Локализация 📚
📦 YAML | Прототип 📦
labels
Collaborator
|
А зачем? Еще куча оружия которое в билде будет валятся и путать всех |
Contributor
Author
Это часть оружек фракции, перенос осуществляется фракции целиком, так-то вырезать можно но там довольно высокое качество спрайтов, очень хорошие оружки |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Краткое описание | Short description
Данный pull-request переносит фракцию Med-Tak (Trauma team) - военизированные парамедики, могут быть использованы в качестве ивентовых персонажей/эвакуация экипажа в критических ситуациях.
Также pull request затрагивает некоторые вещи ТСФ
Ссылка на багрепорт/Предложение | Related Issue/Bug Report
Медиа (Видео/Скриншоты) | Media (Video/Screenshots)
🆑 Fooksy2304
Summary by CodeRabbit
Новое содержимое
Новые возможности
Локализация
Графика и аудио