замена ванильного РПС сб#1054
Conversation
замена спрайта, спрайт одобрен мордастом
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (4)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Кто тебе помогал делать ПР? |
Я |
|
Он ещё не научился писать в гите |
|
@CodeRabbit есть ли ошибки в данном ПРе? |
|
@CodeRabbit Заяц где ответ? |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Get PR details and changed files
gh pr view 1054 --repo space-sunrise/project-fire --json title,body,files,state,reviews,checks
echo "---FILES---"
gh pr diff 1054 --repo space-sunrise/project-fire --name-onlyLength of output: 1220 🏁 Script executed: #!/bin/bash
# Check the meta.json for the RSI
cat Resources/Textures/Clothing/Belt/securitywebbing.rsi/meta.json
echo "---IMAGE INFO---"
# Check image dimensions of the changed files
for f in Resources/Textures/Clothing/Belt/securitywebbing.rsi/*.png; do
echo "$f:"
python3 -c "
from PIL import Image
img = Image.open('$f')
print(' size:', img.size, 'mode:', img.mode)
" 2>/dev/null || identify "$f" 2>/dev/null || file "$f"
doneLength of output: 1641 🏁 Script executed: #!/bin/bash
# Read PNG dimensions using Python struct (no PIL needed)
python3 << 'EOF'
import struct, zlib, os
def get_png_size(path):
with open(path, 'rb') as f:
sig = f.read(8)
if sig != b'\x89PNG\r\n\x1a\n':
return None, None
f.read(4) # length
chunk_type = f.read(4)
if chunk_type != b'IHDR':
return None, None
w = struct.unpack('>I', f.read(4))[0]
h = struct.unpack('>I', f.read(4))[0]
return w, h
base = "Resources/Textures/Clothing/Belt/securitywebbing.rsi"
for fname in ["icon.png", "equipped-BELT.png", "inhand-left.png", "inhand-right.png"]:
path = os.path.join(base, fname)
w, h = get_png_size(path)
print(f"{fname}: {w}x{h}")
EOFLength of output: 881 🏁 Script executed: #!/bin/bash
# Check another belt RSI with 4-direction states for comparison
python3 << 'EOF'
import struct, os, json
def get_png_size(path):
try:
with open(path, 'rb') as f:
sig = f.read(8)
if sig != b'\x89PNG\r\n\x1a\n':
return None, None
f.read(4)
chunk_type = f.read(4)
if chunk_type != b'IHDR':
return None, None
w = struct.unpack('>I', f.read(4))[0]
h = struct.unpack('>I', f.read(4))[0]
return w, h
except:
return None, None
# Check a few other belt RSIs for comparison
belt_dir = "Resources/Textures/Clothing/Belt"
count = 0
for rsi_name in os.listdir(belt_dir):
rsi_path = os.path.join(belt_dir, rsi_name)
meta_path = os.path.join(rsi_path, "meta.json")
if not os.path.isfile(meta_path):
continue
with open(meta_path) as f:
meta = json.load(f)
# Check if it has 4-direction states
has_4dir = any(s.get('directions') == 4 for s in meta.get('states', []))
if has_4dir:
print(f"\n=== {rsi_name} ===")
for fname in os.listdir(rsi_path):
if fname.endswith('.png'):
w, h = get_png_size(os.path.join(rsi_path, fname))
print(f" {fname}: {w}x{h}")
count += 1
if count >= 3:
break
EOFLength of output: 3202
"copyright": "Taken from tgstation at commit https://github.com/tgstation/tgstation/commit/c838ba21dae97db345e0113f99596decd1d66039, tweak by `@mureixlol`, resprite by `@RJD1TOP1`" |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Get PR details and files changed
gh pr view 1054 --repo space-sunrise/project-fire --json title,body,files,state,additions,deletions
echo "---FILES CHANGED---"
gh pr diff 1054 --repo space-sunrise/project-fire --name-onlyLength of output: 1549 🏁 Script executed: #!/bin/bash
# Check if meta.json exists in the RSI dir and if there's a changelog entry
fd "meta.json" Resources/Textures/Clothing/Belt/securitywebbing.rsi/
# Check for changelog files in the PR
gh pr diff 1054 --repo space-sunrise/project-fire | grep -i "changelog\|yml\|yaml" || echo "No changelog files found"
# List all files in that RSI directory
ls Resources/Textures/Clothing/Belt/securitywebbing.rsi/ 2>/dev/null || echo "Directory not found in local checkout"
# Check if there's a changelog requirement in CONTRIBUTING or similar
fd "CONTRIBUTING" --max-depth 2Length of output: 792 🏁 Script executed: #!/bin/bash
# Check CONTRIBUTING.md for changelog requirements
cat CONTRIBUTING.md | head -100
echo "---META.JSON---"
cat Resources/Textures/Clothing/Belt/securitywebbing.rsi/meta.jsonLength of output: 1475
В остальном всё в порядке: все 4 состояния спрайта ( |
3 participants
замена спрайта, спрайт одобрен мордастом
Краткое описание | Short description
респрайт ВАНИЛЬНОГО РПС, того что лежит в ящиках и выдается в автоматах