Good Dockerfile: 35% smaller image / 77% fewer CVEs #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces a more optimal Dockerfile that utilizes a multi-stage build to produce a production image with only absolutely necessary components. Plus the new container won't run as root. The results: ``` $ docker images podcastfy REPOSITORY TAG IMAGE ID CREATED SIZE podcastfy slim-ubuntu 8fa6ecf34d32 About a minute ago 1.35GB podcastfy python3 ae1c62703189 25 hours ago 1.4GB podcastfy original ada6130f3ef2 25 hours ago 2.11GB ``` Original image: ``` $ trivy image ghcr.io/souzatharsis/podcastfy:latest Total: 1045 (UNKNOWN: 0, LOW: 79, MEDIUM: 963, HIGH: 3, CRITICAL: 0) ``` Improved image: ``` $ trivy image podcastfy:slim-ubuntu Total: 232 (UNKNOWN: 0, LOW: 28, MEDIUM: 204, HIGH: 0, CRITICAL: 0) ```
iximiuz
force-pushed
the
good-dockerfile
branch
from
6f26480 to
4f5a789
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[with @kcq] This PR introduces a more optimal Dockerfile that utilizes a multi-stage build to produce a production image with only absolutely necessary components. Plus the new container won't run as root.
The results:
Original image:
Improved image: