Fix Cant create ICMP firewall rules on windows

[alexandrezia]

Description

on windows icmp rules must not specify port

Issues Resolved

#156

Check List

• All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
• New functionality includes testing.
• New functionality has been documented in the README if applicable
• All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

[ianau74]

Can you fix the 2 failing checks so this can get merged into master? They seem like pretty trivial fixes.

[mjavier2k]

Im having the same issue and a merge into master will be appreciated.

[smastrorocco]

Any chance we can get this merged?

[RiverHeart]

Hey @alexandrezia I realize this was opened a long time ago but would you be willing to resubmit this? If not, would it be okay if I resubmitted this as a different PR attribution to you?

[alexandre-zia-ifood]

Hey @alexandrezia I realize this was opened a long time ago but would you be willing to resubmit this? If not, would it be okay if I resubmitted this as a different PR attribution to you?

Hey, it was too long ago, I don't have context about this anymore, please go ahead, no worries.

[RiverHeart]

Hey @alexandrezia I realize this was opened a long time ago but would you be willing to resubmit this? If not, would it be okay if I resubmitted this as a different PR attribution to you?

Hey, it was too long ago, I don't have context about this anymore, please go ahead, no worries.

Thanks @alexandrezia :)