Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: when lingroups are provided, use them for csv_summary #3311

Merged
merged 15 commits into from
Oct 24, 2024

Conversation

bluegenes
Copy link
Contributor

@bluegenes bluegenes commented Aug 26, 2024

Currently, when we generate a csv_summary with LINs, we get a summary at every single LIN rank, which is a lot of results and not very helpful. LINgroups are our way of linking the LINs (e.g. 14;1;0;0;0;0;0;0;0;0) to a known name/taxonomic group (e.g. "Phylotype I").

This PR changes the behavior of csv_summary when a lingroup file is provided, limiting summarized reporting to just the named lingroups. While the output is very similar to the lingroup output we already have, the most important difference is that the sample name is included in the output, meaning that we get intelligible results when running tax metagenome on more than one sample.

Prior tax metagenome behavior was to always generate a lingroup output file when a lingroups file is provided. Here, I disable that for multiple queries, since the results wouldn't make sense. I do not replace it with another default, but I did add a recommendation to the help + doc.

In the future, we could consider changing the default lingroup output to csv_summary, since it's actually useful for multiple files. Or, we could modify the lingroup output to include query information.

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.40%. Comparing base (5acf698) to head (e3c3bb6).
Report is 1 commits behind head on latest.

Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #3311      +/-   ##
==========================================
+ Coverage   86.45%   92.40%   +5.94%     
==========================================
  Files         137      104      -33     
  Lines       16070    12925    -3145     
  Branches     2211     2219       +8     
==========================================
- Hits        13894    11943    -1951     
+ Misses       1869      675    -1194     
  Partials      307      307              
Flag Coverage Δ
hypothesis-py 25.43% <8.00%> (-0.04%) ⬇️
python 92.40% <100.00%> (+<0.01%) ⬆️
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bluegenes
Copy link
Contributor Author

@sourmash-bio/devs ready for review

@bluegenes bluegenes changed the title WIP: when lingroups are provided, use them for csv_summary MRG: when lingroups are provided, use them for csv_summary Sep 4, 2024
Copy link
Contributor

@ctb ctb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - esp appreciate the documentation update.

there's some missing code coverage - is this just buggy codecov? I haven't dug in at all.

@ctb
Copy link
Contributor

ctb commented Sep 18, 2024

oh! I wanted to suggest that you put the suggested changes to behavior in the PR description into new issues, too; I think they require a major version bump?

@bluegenes
Copy link
Contributor Author

looks good - esp appreciate the documentation update.

there's some missing code coverage - is this just buggy codecov? I haven't dug in at all.

looks like it was just buggy codecov!

@bluegenes
Copy link
Contributor Author

oh! I wanted to suggest that you put the suggested changes to behavior in the PR description into new issues, too; I think they require a major version bump?

now in #3361

@bluegenes bluegenes merged commit 6ae9cd3 into latest Oct 24, 2024
43 of 44 checks passed
@bluegenes bluegenes deleted the better-summarized-lingroups branch October 24, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

csv_summary format not created for multiple queries (tax metagenome)
2 participants