DRAFT tool: defra-kv -- key-value store via defradb embedded in CLI tool #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a first-draft of a tool that satisfies the following design priorities:
- written in go
- acts as CLI tool
- embeds defradb in-process
- persists to disk (via Badger)
- creates a basic key-value type store (via an embedded `type` DDL)
- accepts parameters to set config, like keyring-secret and data-root
- primary input is a graphql-form query against the defra, such as `query { .. }` or `mutation { .. }`
- accepts query input either via stdin or `-query` CLI parameter
- includes a few helpful affordances such as home-dir expansion, default root dir, pretty JSON printing, etc.
Added `-has`, `-get`, `-set`, and `-remove` CLI commands
Per fix in #3992, now passing JSON objects as variables works, instead of needing to serialize and inline them into the query. Yay!
rename `defra-kv.go` to `defra-kv/main.go` removed unnecessary/ineffective bits of stdio muting/override, fixed log_level env name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this isn't explicitly intended to actually add to the repo in its current form. It may be added or not, but that's not the goal at the moment. The point here is only code review.
This code was heavily generated by ChatGPT, so my goal is to get a sense of whether any parts of this code are good, bad, or neutral, and learn better how such a program should be coded.
This is a first-draft of a tool that satisfies the following design priorities:
typeDDL)query { .. }ormutation { .. }-queryCLI parameternow also includes KV actions via convenience parameters:
-haschecks if a key exists in the KV store-getlooks up an entry by key name-setinserts (or updates) a key/value into the KV store-removeremoves an entry by key name