This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Code Insights: Improve dashboard select UI #43029
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
838972d
Refactor Popover UI
vovakulikov cc55989
Fix Combobox UI
vovakulikov 4883181
Connect forward ref and truncated text element
vovakulikov 54622c5
Make all dashboard names unique
vovakulikov f3b2d28
Refactor DashboardSelect UI (use combobox + popover over the reach ui…
vovakulikov 4d6db1c
Remove legacy dashboard select UI components
vovakulikov cb0dd86
Remove @reach/listbox styles from the main style entry
vovakulikov 903203e
Fix dashboard content import
vovakulikov 24798ff
Fix combobox popover close logic
vovakulikov 65e0a6b
Fix dashboard page unit tests
vovakulikov 734e007
Update dashboard select story
vovakulikov 28c1414
Fix unit tests of UI components that use popover UI
vovakulikov dc5275d
Update feedback prompt unit tests
vovakulikov 32971be
Fix chart tooltip return to target logic
vovakulikov 6b7f0f6
Fix insight integration tests (dashboard select selectors)
vovakulikov 41e8b9e
Fix layout and dashboard option selectors
vovakulikov d068b76
Bring back async tether scheduling
vovakulikov 57c6087
Fix jest snapshots
vovakulikov 893613a
Remove reach ui listbox package
vovakulikov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how I feel about this. I assume this would not be common, but also it's user specific so my
Chris Dashboard
might be yourChris Dashboard 2
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, you're right that there is a possibility to have non-consistent dashboard names. I don't like this behaviour either. I did this because reach ui combobox doesn't work with non unique items. I think this problem is bad anyway (with number suffix or without)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree two with the same name is just as bad so I don't consider this a blocker if the change brings other positive benefits.