fix: update internal registry from legacy to new revamp registry #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace us-central1-docker.pkg.dev/sourcegraph-ci/rfc795-internal with us-docker.pkg.dev/sourcegraph-images/internal - Fixes release creation failures due to images being published to new registry - Updates both release.yaml and batch-change/release.yaml Co-authored-by: Amp <[email protected]> Amp-Thread-ID: https://ampcode.com/threads/T-46b94b32-5f81-4b16-aa6c-e50cbabb6dde
cloudyadi
approved these changes
Aug 7, 2025
DaedalusG
added a commit
that referenced
this pull request
Aug 7, 2025
…amp registry (#318) ## Problem The release creation process was failing with 404 errors when trying to fetch images like cadvisor:6.6.2517 from the legacy internal registry. ## Root Cause Recent changes in the main sourcegraph repo migrated from legacy registries to new 'revamp' registries, but the deploy repos were still hardcoded to use the old registry. ## Solution - Replace `us-central1-docker.pkg.dev/sourcegraph-ci/rfc795-internal` with `us-docker.pkg.dev/sourcegraph-images/internal` - Updated both release.yaml and batch-change/release.yaml - Tested and confirmed images exist in the new registry ## Test Plan - Validated that cadvisor:6.6.2517 exists in new registry but not in old registry - Successfully tested sg ops update-images command with new registry - Confirmed this fixes the original 404 errors during release creation <br> Backport 96a1e8f from #317 Co-authored-by: Warren Gifford <[email protected]> Co-authored-by: Amp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The release creation process was failing with 404 errors when trying to fetch images like cadvisor:6.6.2517 from the legacy internal registry.
Root Cause
Recent changes in the main sourcegraph repo migrated from legacy registries to new 'revamp' registries, but the deploy repos were still hardcoded to use the old registry.
Solution
us-central1-docker.pkg.dev/sourcegraph-ci/rfc795-internalwithus-docker.pkg.dev/sourcegraph-images/internalTest Plan