refactor(chat): Remove loading dots from context display #7557
+97
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follows up on #7502 which add the LoadingDots at Transcript level, where the LoadingDots will show up at the end of the transcript when there is an assistant message in progress. This commit refactors the `ContextCell` component to remove the `LoadingDots` component and simplify the display of context items. The `LoadingDots` component was previously used to indicate that the context was loading. However, it was only displayed when `isContextLoading` was true and `isAgenticChat` was false. This logic was removed, and the context items are now always displayed within the `AccordionContent`. This change simplifies the component and improves the user experience by providing a consistent display of context items, regardless of the loading state or chat mode. ## Test Plan Ensures there are no multple loading dots showing up in the UI at any time.
dominiccooney
approved these changes
Mar 26, 2025
There was a problem hiding this comment.
Thank you for fixing this!
Could you add a touch more detail to the test plan? Verifying that they don't appear "at any time" covers a lot... If any load triggers it, the test plan can just be that: Step 1, make a chat and verify that there's only one set of dots. Done.
abeatrix
added a commit
that referenced
this pull request
Mar 28, 2025
…ay (#7597) Follows up on #7502 which add the LoadingDots at Transcript level, where the LoadingDots will show up at the end of the transcript when there is an assistant message in progress. This commit refactors the `ContextCell` component to remove the `LoadingDots` component and simplify the display of context items. The `LoadingDots` component was previously used to indicate that the context was loading. However, it was only displayed when `isContextLoading` was true and `isAgenticChat` was false. This logic was removed, and the context items are now always displayed within the `AccordionContent`. This change simplifies the component and improves the user experience by providing a consistent display of context items, regardless of the loading state or chat mode. ## Test Plan Ensures there are no multple loading dots showing up in the UI at any time. <br> Backport 656e2c3 from #7557 Co-authored-by: Beatrix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up on #7502 which add the LoadingDots at Transcript level, where the LoadingDots will show up at the end of the transcript when there is an assistant message in progress.
This commit refactors the
ContextCellcomponent to remove theLoadingDotscomponent and simplify the display of context items.The
LoadingDotscomponent was previously used to indicate that the context was loading. However, it was only displayed whenisContextLoadingwas true andisAgenticChatwas false. This logic was removed, and the context items are now always displayed within theAccordionContent.This change simplifies the component and improves the user experience by providing a consistent display of context items, regardless of the loading state or chat mode.
Test Plan
Ensures there are no multple loading dots showing up in the UI at any time.