enhance: Improve shared issue tracker handling in RepositoryConfigure #1610
+41
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when it's not necessary (sourcegit-scm#1577) Signed-off-by: leo <[email protected]>
Refactor the handling of shared issue trackers by reusing the `Commands.SharedIssueTracker` instance. Enhance the removal logic to check for the existence of the tracker file and delete it if empty.
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the shared issue tracker handling in the RepositoryConfigure view model by optimizing object creation and improving cleanup logic. The changes focus on reusing a single SharedIssueTracker instance and adding comprehensive file cleanup when removing issue tracker rules.
- Refactored to reuse a single SharedIssueTracker instance instead of creating multiple instances
- Enhanced removal logic to check if the tracker file exists and is empty before deletion
- Added file system operations to clean up empty issue tracker files
|
Whether to delete the |
love-linger
force-pushed
the
develop
branch
3 times, most recently
from
072502a to
5ce919a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the handling of shared issue trackers by reusing the
Commands.SharedIssueTrackerinstance. Enhance the removal logic to check for the existence of the tracker file and delete it if empty.