enhance: add color element to local changes count to increase visibility #1592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
love-linger
force-pushed
the
develop
branch
5 times, most recently
from
05dba32 to
6822ae3
Compare
scotc-dev
changed the title
|
love-linger
force-pushed
the
develop
branch
3 times, most recently
from
072502a to
5ce919a
Compare
|
NOTE: The blueish highlight is elsewhere used to indicate a selected tab/item (like the Home icon in your screenshot) or an activated option (for toggle-buttons), so IMHO it looks a bit misleading when used on a count-badge that is just there for indication. |
|
It might just be me, I just find the white on grey to be hard to see. |
If that is a general concern / preference, you might want to try a custom color-theme (or create your own) with more contrast : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I always felt that the local changes does not have enough visual feedback to to show changes.
It may even be worth including the count in the tab to the left of the respository name - thoughts?