Skip to content

fix: support 'L', 'LL', 'UL' suffix in integer literals & correct float negation in WAT generator#17

Open
morpheuschoo wants to merge 2 commits into
source-academy:mainfrom
morpheuschoo:fix-long-and-float
Open

fix: support 'L', 'LL', 'UL' suffix in integer literals & correct float negation in WAT generator#17
morpheuschoo wants to merge 2 commits into
source-academy:mainfrom
morpheuschoo:fix-long-and-float

Conversation

@morpheuschoo

@morpheuschoo morpheuschoo commented May 11, 2025

Copy link
Copy Markdown

Fix:

  • suffixes ll, l, ul, and their uppercase equivalents were not recognised. This PR fixes this.
  • fixes the floating-point negation in the WAT generator.

@uylulu uylulu left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@benmurphyy

Copy link
Copy Markdown
Contributor

Thanks, perhaps add some tests verifying exactly what you fixed in ctowasm/test/samples? You can create a new folder for it, or use subset4 since thats where floats were first introduced, just remember to add the entry for each test in ctowasm/test/testLog.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants