-
Notifications
You must be signed in to change notification settings - Fork 56
Added Exam mode #1236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Added Exam mode #1236
Changes from 27 commits
fc72d29
2fc38ca
9953b9c
f450e85
0bb9857
d7ad8b3
f216d1b
48fff28
b5f2722
bc4c48c
46c2ff0
fe80662
f3c9ea9
665ad2a
abb1014
82afebf
1db4420
d88eeba
d9a97e3
40ea386
7ae6f14
e62fcef
e0330f2
d971fcd
40ce982
0302764
7fcbc89
cad39c8
46af8d7
6531376
3dcc288
31bbf5a
48c1b10
e0758fb
9154177
7bd79fd
ed16cb4
22a5704
6cba5f5
f6ab358
b99a82d
604b61b
ca082c9
398bee0
1c3d787
434d21c
58906d7
7d1a400
f1ed0bc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -9,7 +9,11 @@ | |||||||||
| def index(conn, %{"course_id" => course_id}) when is_ecto_id(course_id) do | ||||||||||
| case Courses.get_course_config(course_id) do | ||||||||||
| {:ok, config} -> | ||||||||||
| render(conn, "config.json", config: config) | ||||||||||
| if conn.assigns.course_reg.role == :admin || conn.assigns.course_reg.role == "admin" do | ||||||||||
| render(conn, "config_admin.json", config: config) | ||||||||||
|
||||||||||
| render(conn, "config_admin.json", config: config) | |
| # Remove resume_code before rendering for admins | |
| config_admin = Map.delete(config, :resume_code) | |
| render(conn, "config_admin.json", config: config_admin) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why this is linked to the user and not their course_registration? Isn't exam mode related to their course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initially I thought linking this to the user would allow for the enforcing of the pause beyond the course so that if a user is paused due to opening other app / using dev tool (which is our plan), the user will have to settle the problem with the course admin / coordinator. But, now that you pointed out, maybe this should not affect the user through all their courses. Should I move this course_registration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RichDom2185 thoughts?