Ensure TIMESTAMP presents date-time in English locale format for SRP authentication #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…authentication compatibility, regardless of phone's locale
|
|
|
@adam-fowler updated the pull request, thanks |
|
Hello @adam-fowler ! I noticed that some checks failed. To verify, I ran the tests locally without my proposed changes and encountered the same error. This confirms that the issue isn't due to the locale change. Given this, what's the next step for this PR? Currently, I'm using my fork because authentication with SRP isn't possible when the phone's locale isn't set to English. |
|
I've seen this on other repo's. It looks like an issue with codecov. |
|
I'll merge this and have a closer look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not possible to authenticate when your iPhone's locale is not English. The error is thrown:
With my fix, the TIMESTAMP will present date-time in English locale format which will avoid the reported issue.