Branch - #451
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #53
Summary
Closes #
Type of change
Checklist
Build & tests
go build ./...passesmake testpasses (the unit suite)make lintpasses (golangci-lint run)make test-dbpasses against a throwawayTEST_DATABASE_URLtable-drivenwhere practical)Docs & config
README.mdupdated if API endpoints, request/response shape, or env vars changed (theAPI referenceand config table)docs/*.mdupdated if architecture, replay, backfill, or logging flows changedCONTRIBUTING.mdupdated if conventions changed in a way this PR template no longer reflects (so the two stay in sync — one source of truth)Operator-facing
sorotrail replay --from-ledger Nafter upgrading, otherwise the change only applies to events ingested from then on.up.sqland.down.sqlfiles are checked in; no applied migration is editedOut-of-scope / follow-ups
Testing notes