Merge pull request #841 from warpcomdev/feature/strict_sync_repl

Add ability to disable sync replication when there're not enough ready standbys.
sorintlab · Sep 16, 2021 · fc23394 · fc23394
2 parents d743ed5 + e48f9a4
commit fc23394
Show file tree

Hide file tree

Showing 7 changed files with 907 additions and 74 deletions.
diff --git a/cmd/sentinel/cmd/sentinel.go b/cmd/sentinel/cmd/sentinel.go
@@ -1078,7 +1078,7 @@ func (s *Sentinel) updateCluster(cd *cluster.ClusterData, pis cluster.ProxiesInf
 						newMasterDB.Spec.SynchronousStandbys = append(newMasterDB.Spec.SynchronousStandbys, oldMasterdb.UID)
 					}
 				}
-				if len(newMasterDB.Spec.SynchronousStandbys) == 0 {
+				if len(newMasterDB.Spec.SynchronousStandbys) == 0 && *clusterSpec.MinSynchronousStandbys > 0 {
 					newMasterDB.Spec.ExternalSynchronousStandbys = []string{fakeStandbyName}
 				}